Narek/bm25 bloom #343
Merged
Narek/bm25 bloom #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Hi! Looks like you've reached your API usage limit. You can increase it from your account settings page here: app.greptile.com/settings/usage
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
|
dqii
reviewed
Oct 15, 2024
Ngalstyan4
force-pushed
the
narek/bm25_bloom
branch
from
76d0c5f to
a602574
Compare
Benchmarks
|
Ngalstyan4
force-pushed
the
narek/bm25_bloom
branch
from
68feaa8 to
d90fd21
Compare
Ngalstyan4
force-pushed
the
narek/bm25_bloom
branch
3 times, most recently
from
2f0a524 to
2d867b3
Compare
Ngalstyan4
force-pushed
the
narek/bm25_bloom
branch
3 times, most recently
from
5440658 to
3419924
Compare
.cargo/config has been deprecated in favor of config.toml since rust 1.38. We use Rust 2021 edition, which is stable since 1.56, so it should be fine to rename the file and avoid the warning during compilation
bm25 agg
Ngalstyan4
force-pushed
the
narek/bm25_bloom
branch
from
f459c4b to
a0a7c42
Compare
var77
reviewed
Nov 15, 2024
lantern_extras/src/bm25_agg.rs
Outdated
| client | ||
| .select( | ||
| &format!( | ||
| "SELECT term, term_freq FROM {}_bm25 WHERE term = ANY(text_to_stem_array('{}'));", |
There was a problem hiding this comment.
do we need to quote_ident the table name to support upper-case table names or is it guaranteed to be lowercase?
var77
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.