Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add openai completion API to SQL and daemon #341

Merged
merged 15 commits into from
Oct 20, 2024
Merged

Conversation

var77
Copy link
Collaborator

@var77 var77 commented Oct 14, 2024

  • Add SQL function to call OpenAI completion API
  • Refactor embedding jobs, remove CSV exporter, make db_exporter more generic

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Hi! Looks like you've reached your API usage limit. You can increase it from your account settings page here: app.greptile.com/settings/usage

17 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

github-actions bot commented Oct 14, 2024

Benchmarks

metric old new pct change
recall (after create) 0.950 0.955 +0.53%
recall (after insert) 0.000 0.000 -
select tps 26607.539 24202.087 -9.04%
select bulk(100) tps 35.451 35.637 +0.52%
select latency (ms) 0.722 ± 1.642𝜎 0.705 ± 1.647𝜎 -2.35%
select bulk(100) latency (ms) 874.591 ± 110.647𝜎 865.651 ± 114.940𝜎 -1.02%
create latency (ms) 393139.712 395969.102 +0.72%
insert tps 471.130 466.257 -1.03%
insert bulk(100) tps 5.017 5.048 +0.62%
insert latency (ms) 67.257 ± 14.674𝜎 68.013 ± 15.906𝜎 +1.12%
insert bulk(100) latency (ms) 6230.209 ± 137.708𝜎 6208.913 ± 133.992𝜎 -0.34%
disk usage (bytes) 8192008192.000 8192008192.000 -

@CLAassistant
Copy link

CLAassistant commented Oct 15, 2024

CLA assistant check
All committers have signed the CLA.

@var77 var77 changed the title add SQL function `openai_completion(query, model, context, base_url); add openai completion API to SQL and daemon Oct 15, 2024
var77 added 6 commits October 16, 2024 19:11
…check model before starting the job, combine common logic of checking model into a macro, add test to check inputs with special characters
…lm_token as alias to openai_token and cohere_token, rename openai_completion to llm_completion
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intended to be included?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was by mistake thanks for noticing!

@var77 var77 force-pushed the varik/openai-completion branch from 7b0568d to 5ef59f1 Compare October 20, 2024 09:29
@var77 var77 merged commit 04aafd5 into main Oct 20, 2024
125 of 129 checks passed
@var77 var77 deleted the varik/openai-completion branch October 20, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants