-
Notifications
You must be signed in to change notification settings - Fork 16.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community: Escapes AzureCosmosDBNoSqlVectorStore hybrid & full text queries that contain single quotes #29339
base: master
Are you sure you want to change the base?
Conversation
BenMcH
commented
Jan 21, 2025
•
edited
Loading
edited
- Description: Escapes vector store searches which contain a single quote, as these will currently result in an error and not search for relevant documents.
- Issue: [Azure CosmosDB NoSQL] similarity_search_with_score function returning CosmosHttpResponseError "bad request" #27269
- Dependencies: N/A
- Twitter handle: https://x.com/mchonedev
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
It seems that most if not all of these failures are due to failures in other packages Edit: Turns out I was using a python feature not supported by older versions. This is fixed now! |
0a035e3
to
490afb0
Compare
@efriis any chance I could get a review on this? Should be a really quick one 🤠 |
@eyurtsev Could this PR get prioritized? It would be nice to have the option to use hybrid / full text search |
cc @marlenezw - any news on the cosmos integrations moving to https://github.com/langchain-ai/langchain-azure ? |
I'll be interested in knowing if it is moving as well. I have encountered a few other improvements that I'd be happy to submit pull requests for. Things like assuming the partition key is the id meaning we need to use the container directly to perform certain actions |
Yes we've just merged some updates in the latest release!! @BenMcH can you make this PR with the new integrations here https://github.com/langchain-ai/langchain-azure/blob/main/libs/azure-ai/langchain_azure_ai/vectorstores/azure_cosmos_db_no_sql.py |