core: Cache RunnableLambda __repr__ #29199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
the
🤖:nit
ccurme
reviewed
Jan 14, 2025
| @@ -4351,6 +4351,8 @@ def __init__( | |||
| except AttributeError: | |||
| pass | |||
|
|
|||
| self.repr: str | None = None | |||
There was a problem hiding this comment.
should this be private? i.e., self._repr
efriis
reviewed
Jan 16, 2025
| return f"RunnableLambda(afunc={get_lambda_source(self.afunc) or '...'})" | ||
| else: | ||
| return "RunnableLambda(...)" | ||
| if self._repr is None: |
There was a problem hiding this comment.
similar comment to last one - why not decorate with @functools.lru_cache instead?
There was a problem hiding this comment.
Using lru_cache on instance methods can lead to memory leaks (as self is hard referenced by the cache)
See https://docs.astral.sh/ruff/rules/cached-instance-method/
Do you prefer the solution with an lru_cache external function or the attribute memoizer ?
# Conflicts: # libs/core/langchain_core/runnables/base.py
ccurme
approved these changes
Jan 23, 2025
dosubot
bot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RunnableLambda's__repr__may do costly OS operation by callingget_lambda_source.So it's better to cache it.
See #29043