vertexai: Preserve sparse_embeddings in data_points_to_batch_update_records
#721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Fix missing
sparse_embeddingsinvector_store.add_texts_with_embeddings()for Vertex AI indexThis PR ensures that
sparse_embeddingsare correctly stored in the Vertex AI index when usingvector_store.add_texts_with_embeddings(). Previously,sparse_embeddingswere not included in the index due to their absence in thedata_points_to_batch_update_recordsfunction. This prevented hybrid search from functioning as expected.Relevant Issues
Fixes issue #720 - sparse_embeddings are not stored in Vertex AI index when using add_texts_with_embeddings
Type
🐛 Bug Fix
Changes(optional)
As described in issue #720.
data_points_to_batch_update_records(inlibs/vertexai/langchain_google_vertexai/vectorstores/_utils.py) to includesparse_embeddingsin the update records.sparse_embeddingsare properly formatted and stored.Testing(optional)
Note(optional)