Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor lowering code to use Arenas/cleanup #175

Draft
wants to merge 13 commits into
base: struct_generics
Choose a base branch
from
Draft

Conversation

edg-l
Copy link
Member

@edg-l edg-l commented Feb 7, 2025

Refactors the lowering code to use arenas, and also use it to cleanup the lowering code as now i know more or less the patterns.

@edg-l edg-l changed the base branch from main to struct_generics February 7, 2025 09:49
Copy link

github-actions bot commented Feb 7, 2025

Benchmarking factorial

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 1298 lines in your changes missing coverage. Please review.

Project coverage is 44.00%. Comparing base (c253cdb) to head (730a688).

Files with missing lines Patch % Lines
src/ir/lowering2/expressions.rs 0.00% 333 Missing ⚠️
src/ir/lowering2/lower.rs 0.00% 309 Missing ⚠️
src/ir/lowering2/ir.rs 0.00% 218 Missing ⚠️
src/ir/lowering2/mod.rs 0.00% 176 Missing ⚠️
src/ir/lowering2/types.rs 0.00% 141 Missing ⚠️
src/ir/lowering2/functions.rs 0.00% 47 Missing ⚠️
src/ir/lowering2/constants.rs 0.00% 38 Missing ⚠️
src/ir/lowering2/statements.rs 0.00% 26 Missing ⚠️
src/ast/types.rs 0.00% 10 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##           struct_generics     #175       +/-   ##
====================================================
- Coverage            58.49%   44.00%   -14.50%     
====================================================
  Files                   21       29        +8     
  Lines                 4014     5293     +1279     
====================================================
- Hits                  2348     2329       -19     
- Misses                1666     2964     +1298     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edg-l edg-l changed the title Refactor lowering code to use Arenas Refactor lowering code to use Arenas/improve Feb 10, 2025
@edg-l edg-l changed the title Refactor lowering code to use Arenas/improve Refactor lowering code to use Arenas/cleanup Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants