-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/scalable-integration - Add dynamic and scalable segment integration #18
Closed
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
8ada790
Update README.md
MaiKaY a1c175c
Merge branch 'master' of https://github.com/sribuu/flutter-segment
ariefwijaya 47c1d4b
Update README.md
ariefwijaya 3c7ab9e
Add Dynamic and Scalable Segment Integration
ariefwijaya b2ea9fc
improve implementation of integration on ios
ariefwijaya 5e539bf
remove unused implementation
ariefwijaya e72d323
update documentations
ariefwijaya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,25 @@ | ||
enum SegmentIntegrationItemType { amplitude, unknown } | ||
ariefwijaya marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
class SegmentConfig { | ||
SegmentConfig({ | ||
required this.writeKey, | ||
this.trackApplicationLifecycleEvents = false, | ||
this.amplitudeIntegrationEnabled = false, | ||
this.debug = false, | ||
this.integrationItems, | ||
}); | ||
|
||
final String writeKey; | ||
final bool trackApplicationLifecycleEvents; | ||
final bool amplitudeIntegrationEnabled; | ||
final List<SegmentIntegrationItemType>? integrationItems; | ||
final bool debug; | ||
|
||
Map<String, dynamic> toMap() { | ||
return { | ||
'writeKey': writeKey, | ||
'trackApplicationLifecycleEvents': trackApplicationLifecycleEvents, | ||
'amplitudeIntegrationEnabled': amplitudeIntegrationEnabled, | ||
'debug': debug, | ||
'integrationItems': | ||
integrationItems?.map((e) => e.toString().split(".").last).toList(), | ||
ariefwijaya marked this conversation as resolved.
Show resolved
Hide resolved
|
||
}; | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whats the idea behind this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need this code anymore since these are deprecated:

and also in iOS side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, then it does not relate to this PR right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danielgomezrico I think it's related because it is a breaking change since we can't use an array in the android manifest or .plist. So, We need to remove it then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I dont understand why this is related to this, can you try to explain it again please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danielgomezrico ,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ariefwijaya there is another issue open where initializing the sdk using the dart initialization results in App Installed events not being tracked on iOS:
#26
So while the old implementation is marked as deprecated, we had to revert back to it and rely on it for our iOS integrations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh Thanks for the info, but in my case, I don't get that problem and not related to my implementation.
Because, I just improve our existing dart only installation..
You can continue the discussion about Installed Events not being tracked in this issue #26