feature/scalable-integration - Add dynamic and scalable segment integration #18

ariefwijaya · 2022-03-15T06:21:14Z

Purpose

Change segment third-party integration to enumeration list to be more clean and scalable
Remove the native installation and only use dart code installation
update documentation
Resolve [DISCUSSION][Tech Debt] - Fully Dynamic and Scalable Segment Integration #17 , please check @danielgomezrico

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation Update (if none of the other choices apply)

How to Test

Use plugin and run your apps, as usual using the new parameter

Environment

Please define your environment to test this, you can choose multiple options. Put an x in the boxes that apply

Attach your `flutter doctor -v` inside code block:

[✓] Flutter (Channel stable, 2.5.3, on macOS 12.2 21D49 darwin-x64, locale en-ID)
    • Flutter version 2.5.3 at /Users/ittcel/fvm/versions/stable
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 18116933e7 (5 months ago), 2021-10-15 10:46:35 -0700
    • Engine revision d3ea636dc5
    • Dart version 2.14.4

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/ittcel/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7590822)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 13.2.1, Build version 13C100
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7590822)

[✓] IntelliJ IDEA Community Edition (version 2020.3.4)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.65.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.36.0

[✓] Connected device (2 available)
    • Android SDK built for x86 64 (mobile) • emulator-5554 • android-x64    • Android 9 (API 28) (emulator)
    • Chrome (web)                          • chrome        • web-javascript • Google Chrome 98.0.4758.109

• No issues found!

Expected Results

Plugin working properly

Notes

tested and works 100% in android & ios.

ariefwijaya · 2022-03-16T15:16:42Z

Hi, @danielgomezrico @MaiKaY any update on this?
I've planned to add more integration such as firebase, google analytics, facebook, and so on

lib/src/segment_config.dart

danielgomezrico · 2022-03-17T17:09:12Z

android/src/main/java/com/example/flutter_segment/FlutterSegmentPlugin.java

-
-    try {
-      ApplicationInfo ai = applicationContext.getPackageManager()
-              .getApplicationInfo(applicationContext.getPackageName(), PackageManager.GET_META_DATA);
-
-      Bundle bundle = ai.metaData;
-
-      FlutterSegmentOptions options = FlutterSegmentOptions.create(bundle);
-      setupChannels(options);
-    } catch (Exception e) {
-      Log.e("FlutterSegment", e.getMessage());
-    }


Whats the idea behind this change?

We don't need this code anymore since these are deprecated:

and also in iOS side.

Got it, then it does not relate to this PR right?

@danielgomezrico I think it's related because it is a breaking change since we can't use an array in the android manifest or .plist. So, We need to remove it then.

Sorry, I dont understand why this is related to this, can you try to explain it again please?

The old implementation (Integration using AndroidManifest.xml and ios info.plist) is deprecated.

what I propose here is a new method that will not be compatible with the old implementation. Breaking change.

@danielgomezrico ,

The old implementation (Integration using AndroidManifest.xml and ios info.plist) is deprecated.

what I propose here is a new method that will not be compatible with the old implementation. Breaking change.

@danielgomezrico ,

@ariefwijaya there is another issue open where initializing the sdk using the dart initialization results in App Installed events not being tracked on iOS:
#26

So while the old implementation is marked as deprecated, we had to revert back to it and rely on it for our iOS integrations

Oh Thanks for the info, but in my case, I don't get that problem and not related to my implementation.
Because, I just improve our existing dart only installation..
You can continue the discussion about Installed Events not being tracked in this issue #26

danielgomezrico · 2022-03-17T17:47:08Z

@ariefwijaya thanks for this! Please take a look at my questions here and in the discussion

ariefwijaya · 2022-03-17T23:31:15Z

@ariefwijaya thanks for this! Please take a look at my questions here and in the discussion

@danielgomezrico Thanks for the reply. look forward to hearing your feedback.

ariefwijaya · 2022-03-29T11:43:58Z

@danielgomezrico @MaiKaY any feedbacks guys?

danielgomezrico · 2022-03-30T11:07:19Z

@ariefwijaya since the discussion is not already answered I would continue adding more code, it is better to think a solution a then implement it, there are still some unknowns in the discussion

ariefwijaya · 2022-03-30T14:50:06Z

@ariefwijaya since the discussion is not already answered I would continue adding more code, it is better to think a solution a then implement it, there are still some unknowns in the discussion

I've replied to your question already, have you checked it? @danielgomezrico

julianfalcionelli · 2023-04-20T09:44:02Z

No updates on this? Is great having the integration settings to be dynamic and not just supporting Firebase/Amplitude...

MaiKaY and others added 7 commits January 25, 2022 14:24

Update README.md

8ada790

Merge branch 'master' of https://github.com/sribuu/flutter-segment

a1c175c

Update README.md

47c1d4b

Add Dynamic and Scalable Segment Integration

3c7ab9e

improve implementation of integration on ios

b2ea9fc

remove unused implementation

5e539bf

update documentations

e72d323

danielgomezrico reviewed Mar 17, 2022

View reviewed changes

danielgomezrico requested a review from cdmunoz March 18, 2022 19:56

ariefwijaya requested a review from danielgomezrico March 24, 2022 03:15

ariefwijaya mentioned this pull request Apr 13, 2022

[DISCUSSION][Tech Debt] - Fully Dynamic and Scalable Segment Integration #17

Open

danielgomezrico marked this pull request as draft April 21, 2022 15:24

ariefwijaya mentioned this pull request Jul 11, 2022

Request: Firebase Analytics Support #16

Open

b099l3 mentioned this pull request Aug 11, 2022

Request: Facebook App Events Support #52

Open

sribuu closed this by deleting the head repository Nov 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature/scalable-integration - Add dynamic and scalable segment integration #18

feature/scalable-integration - Add dynamic and scalable segment integration #18

ariefwijaya commented Mar 15, 2022

ariefwijaya commented Mar 16, 2022 •

edited

Loading

danielgomezrico Mar 17, 2022

ariefwijaya Mar 17, 2022

danielgomezrico Mar 18, 2022

ariefwijaya Mar 22, 2022

danielgomezrico Mar 24, 2022

ariefwijaya Mar 28, 2022

savy-91 Aug 3, 2022

ariefwijaya Aug 4, 2022

danielgomezrico commented Mar 17, 2022

ariefwijaya commented Mar 17, 2022

ariefwijaya commented Mar 29, 2022 •

edited

Loading

danielgomezrico commented Mar 30, 2022

ariefwijaya commented Mar 30, 2022

julianfalcionelli commented Apr 20, 2023

feature/scalable-integration - Add dynamic and scalable segment integration #18

feature/scalable-integration - Add dynamic and scalable segment integration #18

Conversation

ariefwijaya commented Mar 15, 2022

Purpose

Types of changes

How to Test

Environment

Expected Results

Notes

ariefwijaya commented Mar 16, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

danielgomezrico commented Mar 17, 2022

ariefwijaya commented Mar 17, 2022

ariefwijaya commented Mar 29, 2022 • edited Loading

danielgomezrico commented Mar 30, 2022

ariefwijaya commented Mar 30, 2022

julianfalcionelli commented Apr 20, 2023

ariefwijaya commented Mar 16, 2022 •

edited

Loading

ariefwijaya commented Mar 29, 2022 •

edited

Loading