trigger next round without waiting for the constant blockProposal dur… #1415
+80
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation if mempool has enough transactions to fill the block
jchappelow
reviewed
Feb 26, 2025
|
|
||
| for { | ||
| select { | ||
| case <-ctx.Done(): | ||
| ce.log.Info("Context cancelled, stopping the new block round") | ||
| return | ||
| case <-ce.mempoolReadyChan: | ||
| ce.log.Info("received mempoolReady signal, proposing a new block") |
| case <-ticker.C: | ||
| // check for the availability of transactions in the mempool or | ||
| // if the leader has any new events to broadcast a voteID transaction | ||
| if ce.mempool.TxsAvailable() || ce.blockProcessor.HasEvents() { | ||
| ce.log.Info("Mempool has atleast 1 transaction, proposing a new block") |
| @@ -251,6 +257,8 @@ func (ce *ConsensusEngine) processBlockProposal(ctx context.Context, blkPropMsg | |||
| ce.stateInfo.mtx.Lock() | |||
| ce.stateInfo.status = Proposed | |||
| ce.stateInfo.blkProp = blkPropMsg | |||
| // record that the block is available with the consensus engine | |||
| // ce.stateInfo.hasBlock.Store(blkPropMsg.height) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 2 things:
blkAnnmessages, if we already downloaded it duringblkPropmessageblockProposaltimeout, if leader has enough transactions to fill the mempool.