Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows Demo Issue #63

Merged
merged 4 commits into from
Nov 30, 2021
Merged

Fix Windows Demo Issue #63

merged 4 commits into from
Nov 30, 2021

Conversation

IritaSee
Copy link
Contributor

According to this comment. I tried to fix the issue related to Windows by:

  1. Created a windows folder inside scripts folder
  2. Rewrote and checked each .sh script and save them inside windows folder
  3. Add a little of Windows installation related guide in the readme

So next time, if we want to run this from a Windows machine, just go to windows folder and all automation should run smoothly
Thank you!

@IritaSee IritaSee added bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers labels Nov 30, 2021
@IritaSee IritaSee requested a review from mattigrthr November 30, 2021 15:30
@IritaSee IritaSee self-assigned this Nov 30, 2021
@IritaSee IritaSee linked an issue Nov 30, 2021 that may be closed by this pull request
Running demo on Windows #62
Closed
mattigrthr
mattigrthr requested changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@mattigrthr mattigrthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just the specification with the PowerShell should be added if applicable.

README.md Outdated Show resolved Hide resolved
@mattigrthr mattigrthr merged commit 7cea7ec into master Nov 30, 2021
@mattigrthr mattigrthr deleted the fixes/windows-installation branch November 30, 2021 15:44
@IritaSee IritaSee restored the fixes/windows-installation branch December 3, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattigrthr mattigrthr mattigrthr approved these changes

Assignees

@IritaSee IritaSee

Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running demo on Windows
2 participants
@IritaSee @mattigrthr