feat(inspect): api for retrieving service hostnames #11865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubdyszkiewicz
added
the
ci/skip-test
jakubdyszkiewicz
force-pushed
the
inspect-hostnames
branch
2 times, most recently
from
fc4908d to
b1294d2
Compare
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
jakubdyszkiewicz
force-pushed
the
inspect-hostnames
branch
from
b1294d2 to
3536693
Compare
jakubdyszkiewicz
requested review from
michaelbeaumont and
slonka
and removed request for
a team
jakubdyszkiewicz
removed
the
ci/skip-test
lahabana
reviewed
Oct 28, 2024
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
lahabana
reviewed
Dec 6, 2024
| required: true | ||
| description: The type of the service | ||
| - in: path | ||
| name: serviceName |
There was a problem hiding this comment.
We agree that this doesn't support URIs yet?
There was a problem hiding this comment.
unique resource identifier (<mesh>_<name>_<namespace>_<zone>_<shortType>_<optionalSection>)
There was a problem hiding this comment.
then no. At least not for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to see hostnames of Mesh*Service in the Global CP.
Implementation information
While we could add new KDSService to retrieve stats of a resource in specific zones and then aggregate this an easier (less expensive to execute, faster, don't depend on the zone) option is to calculate the hostname. We have all the resources in global CP already (because HostnameGenerator from zone is synced to global for visibility). It's just a matter of relabeling properly.
Supporting documentation
Fix #10618