-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(xds): add x-kuma-tags
conditionally
#11076
perf(xds): add x-kuma-tags
conditionally
#11076
Conversation
isn't this for the non-mtls case? |
We don't have extracting tags from cert (aside MTP validation ofc), so listed cases are for both mtls and non-mtls |
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
4411d07
to
e5d8c6c
Compare
…ader Signed-off-by: Jakub Dyszkiewicz <[email protected]>
add x-kuma-tags
conditionally
Reviewer Checklist🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
|
Checklist prior to review
Do not merge for release-2.9. I'd rather put it in 2.10
We use
x-kuma-tags
internally. We add this to outbound HTTP listeners and we remove them on the inbound listeners. Currently, we use this header for 3 thingsFaultInjection
policyMeshFaultInjection
policyRateLimit
policyI'd argue that in 99% cases you don't need it then.
Just a simple app on k8s looks like this:
This is quite a lot of data to put on every single request between Envoys.
Additionally, that's quite a lot of data to put on every single outbound in XDS config. Removing this slims down the XDS config.
Long term this header should be deleted and we should extract this from the certificate on the inbound side.
syscall.Mkfifo
have equivalent implementation on the other OS --ci/
labels to run additional/fewer testsUPGRADE.md
? --