Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dataplanes): add bundle downloading functionality #3329

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

johncowen
Copy link
Contributor

@johncowen johncowen commented Dec 23, 2024

Adds functionality to allow downloading of a bundle of config/logs for a Dataplane.

Closes #3263

Screenshot 2024-12-23 at 15 09 54

The PR currently works, but I feel I might tweak the code slightly, wanted to put it up incase anyone wanted to try it out.

Its also waiting on #3330

Lastly, policy downloading isn't added here as yet, I added an issue to cover that separately #3356

@johncowen johncowen requested a review from a team as a code owner December 23, 2024 15:06
@johncowen johncowen requested review from schogges and removed request for a team December 23, 2024 15:06
@johncowen johncowen marked this pull request as draft December 23, 2024 15:06
Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for kuma-gui ready!

Name Link
🔨 Latest commit a82139f
🔍 Latest deploy log https://app.netlify.com/sites/kuma-gui/deploys/677d4750376c6d000818483c
😎 Deploy Preview https://deploy-preview-3329--kuma-gui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

johncowen added a commit that referenced this pull request Jan 6, 2025
Replaces our old `LoadingBlock` component (and several others) with a
single `XProgress` component with several `:variant`s.

I'll be using this for #3329

Signed-off-by: John Cowen <[email protected]>
@johncowen johncowen force-pushed the feature/download-bundle branch 5 times, most recently from 9df858a to 95d12c2 Compare January 6, 2025 15:51
@johncowen johncowen marked this pull request as ready for review January 6, 2025 15:55
Copy link
Contributor

@schogges schogges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@johncowen johncowen force-pushed the feature/download-bundle branch from 95d12c2 to a82139f Compare January 7, 2025 15:25
@johncowen johncowen merged commit 1aa3b21 into kumahq:master Jan 8, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a "debug dump" button to the dataplane views
2 participants