chore: uses new subscriptions table/drawer layout for zoneIngress #3153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Cowen <[email protected]>
✅ Deploy Preview for kuma-gui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
johncowen
commented
Nov 7, 2024
Signed-off-by: John Cowen <[email protected]>
Signed-off-by: John Cowen <[email protected]>
johncowen
force-pushed
the
chore/zone-ingress-subs
branch
from
853fc66 to
b28e256
Compare
Signed-off-by: John Cowen <[email protected]>
johncowen
force-pushed
the
chore/zone-ingress-subs
branch
from
e2c1906 to
bec0a9d
Compare
Signed-off-by: John Cowen <[email protected]>
Signed-off-by: John Cowen <[email protected]>
johncowen
force-pushed
the
chore/zone-ingress-subs
branch
from
3072023 to
1f2586a
Compare
Signed-off-by: John Cowen <[email protected]>
3 tasks
Signed-off-by: John Cowen <[email protected]>
lahabana
approved these changes
Nov 8, 2024
johncowen
added a commit
that referenced
this pull request
Nov 12, 2024
I made `.kuma.nanodate` and `.kuma.date` for the slightly different date formats we have in the mocks. I only used them in one mock to prove the outputs, and I also updated the same mock to use `semver` and `commitSha`, but we should try to gradually use these as we work on related features. Note this mock along with changes in #3153 mean this mock is now entirely random 🎉 Signed-off-by: John Cowen <[email protected]> Signed-off-by: John Cowen <[email protected]>
johncowen
added a commit
that referenced
this pull request
Nov 13, 2024
…in egress and dpps (#3159) Similar to #3153 implements new table/drawer layouts for subscriptions in both: - ZoneEgress - Dataplanes ... but seeing we now no longer use the old Subscription components, I deleted those here also. --------- Signed-off-by: John Cowen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new Subscription Table/Drawer UI to ZoneIngresses (whilst maintaining old-style for Egress and Dataplanes until we change those also)
Part of: #2921
Lots of failing tests here, so keeping in draft until I've sorted that. I would guess it's probably chore-like updating of tests but we'll see!Turns out we can't use
addRouteNamefrom #3151 due to things being slightly different and weird between dev source and compiled/built source.Instead I reverted to use route config
propshere, which was second favourite option. I plan to improve on this a little more, and if I ever figure out a more reliable way to add a dynamic global like$routeNameI can add it at a later date. In the meantime I'd rather keep this table/drawers feature on track. Apologies for the noisy PR!