-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create DOCKER_USER variable for developer to build and push docker image for test #302
Create DOCKER_USER variable for developer to build and push docker image for test #302
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #302 +/- ##
=========================================
- Coverage 7.64% 7.61% -0.03%
=========================================
Files 90 90
Lines 21357 21357
=========================================
- Hits 1632 1627 -5
- Misses 19602 19605 +3
- Partials 123 125 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
CONTROLLER_IMG ?= surenpi/devops-controller:$(VERSION)-$(COMMIT) | ||
APISERVER_IMG ?= surenpi/devops-apiserver:$(VERSION)-$(COMMIT) | ||
TOOLS_IMG ?= surenpi/devops-tools:$(VERSION)-$(COMMIT) | ||
DOCKER_USER ?= surenpi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer changing this to kubespheredev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me, surenpi
is my personal account. But kubespheredev
is not a user account. So, I suggest replacing DOCKER_USER
to be a better name.
Due to LinuxSuRen/open-source-best-practice#33, I'm going to close this PR and let this chance leave to new contributors. /close |
What this PR dose?
Create DOCKER_USER variable for developer to build and push docker image for test
Why we need it?
Before this PR, if we want to build and push a docker image for test, we may do with the following steps:
Approach 1
Makefile
and modifysurenpai/devops-controller:$(VERSION)-$(COMMIT)
tojohnniang/devops-controller:$(VERSION)-$(COMMIT)
make docker-build-push-controller
Approach 2
make docker-build-push-controller
docker tag surenpi/devops-controller:dev-v3.2.0-alpha.1-7244edd johnniang/devops-controller:dev-v3.2.0-alpha.1-7244edd
docker push johnniang/devops-controller:dev-v3.2.0-alpha.1-7244edd
But now, we just need to execute
DOCKER_USER=johnniang make docker-build-push-controller
to archive task above./kind feature