-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating application security checklist #46326
Creating application security checklist #46326
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
252c1b0
to
1dae29a
Compare
content/en/docs/concepts/security/application-security-checklist.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/security/application-security-checklist.md
Outdated
Show resolved
Hide resolved
78f4f72
to
a93d643
Compare
@NissesSenap I have updated the checklist structure based on your recommendation. Can you expand on
I'm not sure what you mean here. |
a93d643
to
c1c6f4a
Compare
That is great @AnshumanTripathi , I will try to take a deeper look at the update as soon as possible. My point is that the majority of all apps ruining in Kubernetes don't need access to its API. So I would emphasize that custom rbac rules for apps just aren't needed, in the majority of applications. Still good to talk about it, just like you have, but point to that there are limited use cases for it. |
Makes sense. I am not covering applications using Kubernetes client as a part of this checklist. I think having a doc about secure practices for applications that use the Kubernetes API (and operator) can be very helpful. I will create an issue for this :) |
@NissesSenap created kubernetes/sig-security#121 for hardening guide for using Kubernetes API |
c1c6f4a
to
4f75e48
Compare
I'd suggest we place this under |
Actually we can move this checklist and the existing checklist to |
The I don't think we want to kick this in and then follow up with another PR to move it. |
Makes sense. I'll try to make that change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! We could really use this new page.
Here's some advice about how to get this ready to merge.
content/en/docs/concepts/security/application-security-checklist.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/security/application-security-checklist.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/security/application-security-checklist.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/security/application-security-checklist.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/security/application-security-checklist.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/security/application-security-checklist.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/security/application-security-checklist.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/security/application-security-checklist.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/security/application-security-checklist.md
Outdated
Show resolved
Hide resolved
06322b3
to
18bfd54
Compare
Signed-off-by: Anshuman Tripathi <[email protected]> Update based on feedback Signed-off-by: Anshuman Tripathi <[email protected]> Update based on feedback Signed-off-by: Anshuman Tripathi <[email protected]> Update checklist reading guide Signed-off-by: Anshuman Tripathi <[email protected]> Update checklist structure based on feedback Signed-off-by: Anshuman Tripathi <[email protected]> Apply suggestions from code review Adding the suggestions from the last review. Co-authored-by: Tim Bannister <[email protected]> Fix style Signed-off-by: Anshuman Tripathi <[email protected]>
18bfd54
to
86c48ee
Compare
This page, in its current format, with its current contents, doesn't belong to the concepts section. Please consider place it under the references section. |
I think this proposed "application security checklist" aligns with the live "security checklist" page which is aimed towards operators/cluster admins. If we decide references is a better place then a PR can be made to move both of the "checklists" and possibly more like the /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: reylejano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
LGTM label has been added. Git tree hash: 36479c14b720d1addb2eb45e29c2988783bab833
|
Creating an application security checklist.
Issue
kubernetes/sig-security#111
Deploy Preview
https://deploy-preview-46326--kubernetes-io-main-staging.netlify.app/docs/concepts/security/application-security-checklist/