-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security hardening guide for scheduler configuration #45080
base: main
Are you sure you want to change the base?
Security hardening guide for scheduler configuration #45080
Conversation
Welcome @AnshumanTripathi! |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
/sig security |
@kubernetes/sig-security-pr-reviews please take a look |
0728e98
to
2cae0ed
Compare
5958b41
to
90fb6d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more feedback.
beca647
to
2aa72f3
Compare
19972a5
to
ab53e96
Compare
e3ece46
to
b0b839d
Compare
@kubernetes/sig-security-pr-reviews please take a look at this one. SIG Scheduling can confirm details where appropriate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could clarify what we mean by “configurations”. Did you mean command line settings?
a56a358
to
898ba26
Compare
90a0df4
to
b702281
Compare
48f872a
to
aff9201
Compare
a3bc006
to
3006e43
Compare
82c18fd
to
645c130
Compare
3257350
to
0f58ec4
Compare
Signed-off-by: Anshuman Tripathi <[email protected]> [WIP] Security hardening guide for scheduler configurations Signed-off-by: Anshuman Tripathi <[email protected]> Updates after passing through hemmingway.app Signed-off-by: Anshuman Tripathi <[email protected]> Update scheduling configurations Signed-off-by: Anshuman Tripathi <[email protected]> Apply suggestions from code review Co-authored-by: Tim Bannister <[email protected]> Co-authored-by: Daniel Register <[email protected]> Updates based on PR feedback Signed-off-by: Anshuman Tripathi <[email protected]> Update bind-address definition Signed-off-by: Anshuman Tripathi <[email protected]> Update phrasing of permit-address-sharing Signed-off-by: Anshuman Tripathi <[email protected]> Add -- to args Signed-off-by: Anshuman Tripathi <[email protected]> Sentence case in table title Signed-off-by: Anshuman Tripathi <[email protected]> Reword and correct grammer based on feedback Signed-off-by: Anshuman Tripathi <[email protected]> Remove verbatim argument description Signed-off-by: Anshuman Tripathi <[email protected]> More updates Signed-off-by: Anshuman Tripathi <[email protected]> Update custom scheduler heading and description Signed-off-by: Anshuman Tripathi <[email protected]> Remove dashes on args Signed-off-by: Anshuman Tripathi <[email protected]> Apply suggestions from code review Co-authored-by: Tim Bannister <[email protected]> Signed-off-by: Anshuman Tripathi <[email protected]> Update table title Signed-off-by: Anshuman Tripathi <[email protected]> Update based on feedback Signed-off-by: Anshuman Tripathi <[email protected]> node selector Signed-off-by: Anshuman Tripathi <[email protected]> Feedback Signed-off-by: Anshuman Tripathi <[email protected]> Update authentication and TLS configuration Signed-off-by: Anshuman Tripathi <[email protected]> profiling Signed-off-by: Anshuman Tripathi <[email protected]> Replace tables with bullets Signed-off-by: Anshuman Tripathi <[email protected]> Fix custom scheduler directive and link Signed-off-by: Anshuman Tripathi <[email protected]> style Signed-off-by: Anshuman Tripathi <[email protected]>
0f58ec4
to
0b307ff
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Anshuman Tripathi <[email protected]>
This creates two scheduler profiles: `default-scheduler` and ` my-custom-scheduler`. | ||
Whenever the `.spec` of a Pod does not have a value for `.spec.schedulerName`, the kube-scheduler runs for that Pod, using its main configuration, and default plugins. | ||
If you define a Pod with `.spec.schedulerName` set to `my-custom-scheduler`, the kube-scheduler also runs but with a custom configuration; in that custom configuration, | ||
the `queueSort`, `filter` and `permit` extension points are disabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What in that configuration disables the filter
extension point? Is it bundled in somehow with either queueSort
or permit
?
See #45080 (comment) for some relevant commentary about where these docs should live. |
Creating a scheduler hardening guide as a part of kubernetes/sig-security#30.
Page preview - https://deploy-preview-45080--kubernetes-io-main-staging.netlify.app/docs/concepts/security/hardening-guide/scheduler/