Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-generated DRA canary jobs #34088

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

re-generated DRA canary jobs #34088

wants to merge 1 commit into from
+26 −33

Conversation

bart0sh
Copy link
Contributor

@bart0sh bart0sh commented Jan 7, 2025 •
edited
Loading

The job configs were re-generated in the #34010
Some of the updates can possibly fix current job failures.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 7, 2025
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 7, 2025
@bart0sh
Copy link
Contributor Author

bart0sh commented Jan 7, 2025

/sig node
/cc @pohly @kannon92

@k8s-ci-robot k8s-ci-robot requested review from kannon92 and pohly January 7, 2025 13:48
@bart0sh bart0sh marked this pull request as draft January 7, 2025 13:51
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 7, 2025
@bart0sh bart0sh force-pushed the PR064-update-dra-canary-jobs branch from d4b81e5 to ec5d2ec Compare January 7, 2025 13:55
@bart0sh bart0sh marked this pull request as ready for review January 7, 2025 13:55
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 7, 2025
@k8s-ci-robot k8s-ci-robot requested a review from bobbypage January 7, 2025 13:55
@pohly
Copy link
Contributor

pohly commented Jan 7, 2025

/hold

Let's finish the review of #34010 before merging more potentially intermediate versions of the canary jobs.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2025
@bart0sh
Copy link
Contributor Author

bart0sh commented Jan 7, 2025 •
edited
Loading

@pohly Up to you. However, this update can potentially fix 2 kind jobs.

@bart0sh bart0sh mentioned this pull request Jan 8, 2025
Open
@pohly
Copy link
Contributor

pohly commented Jan 8, 2025

#34010 (comment) and #34010 (review) => now we seem to be at a point where the canary jobs should work and might be final, so let's refresh and try them?

@bart0sh bart0sh force-pushed the PR064-update-dra-canary-jobs branch from ec5d2ec to f846056 Compare January 8, 2025 15:22
@bart0sh
Copy link
Contributor Author

bart0sh commented Jan 8, 2025

@pohly updated, PTAL

@kannon92
Copy link
Contributor

kannon92 commented Jan 8, 2025

/lgtm
/approve

Happy to iterate but we can wait for pohly's approval also.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bart0sh, kannon92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2025
@bart0sh bart0sh force-pushed the PR064-update-dra-canary-jobs branch from f846056 to fe4669c Compare January 8, 2025 17:18
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2025
@bart0sh
Copy link
Contributor Author

bart0sh commented Jan 8, 2025

Updated job names as suggested by @pohly. PTAL.

@pohly
Copy link
Contributor

pohly commented Jan 8, 2025

/lgtm
/cancel hold

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@sjenning sjenning Awaiting requested review from sjenning

@kannon92 kannon92 Awaiting requested review from kannon92

@pohly pohly Awaiting requested review from pohly

@bobbypage bobbypage Awaiting requested review from bobbypage

Assignees

@pohly pohly

@kannon92 kannon92

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Node CI/Test Board
Status: PRs - Needs Approver
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bart0sh @pohly @kannon92 @k8s-ci-robot