Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace pull-crio-cgrpv2-imagefs-separatedisktest with kubetest2 job #33994

Conversation

bart0sh
Copy link
Contributor

@bart0sh bart0sh commented Dec 18, 2024

Replace imagefs-separatedisktest kubernetes_e2e job with kubetest2 job. This is a last step of the job migration.

Ref: #32567

/sig node
/cc @elieser1101 @kannon92 @haircommander

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Dec 18, 2024
@k8s-ci-robot
Copy link
Contributor

@bart0sh: GitHub didn't allow me to request PR reviews from the following users: elieser1101.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Replace imagefs-separatedisktest kubernetes_e2e job with kubetest2 job. This is a last step of the job migration.

Ref: #32567

/sig node
/cc @elieser1101 @kannon92 @haircommander

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 18, 2024
@elieser1101
Copy link
Contributor

Started looking at this and even with the run green it seem to be skipping the actual tests

https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/directory/pull-crio-cgroupv2-imagefs-separatedisktest-kubetest2/1866126888590643200

Ran 0 of 718 Specs in 0.040 seconds
SUCCESS! -- 0 Passed | 0 Failed | 0 Pending | 718 Skipped
PASS

@bart0sh
Copy link
Contributor Author

bart0sh commented Dec 18, 2024

@elieser1101 Thanks for pointing out!
/hold
until we prove that the job works as expected

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2024
@bart0sh
Copy link
Contributor Author

bart0sh commented Dec 18, 2024

@elieser1101

Started looking at this and even with the run green it seem to be skipping the actual tests

There are no tests with SeparateDiskTest keyword, but this is not a kubetest2 issue. old test doesn't run anything either.

@kannon92 Is it a label for some future tests?

@kannon92
Copy link
Contributor

Ah yea. I had a goal to write a test for separate container runtime filesystem but my priorties have shifted.

kubernetes/kubernetes#123346

@bart0sh
Copy link
Contributor Author

bart0sh commented Dec 18, 2024

Great! Feel free to merge this PR then :)
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2024
@kannon92
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bart0sh, kannon92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2024
@k8s-ci-robot k8s-ci-robot merged commit cb09851 into kubernetes:master Dec 18, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@bart0sh: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-node-presubmit.yaml using file config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml

In response to this:

Replace imagefs-separatedisktest kubernetes_e2e job with kubetest2 job. This is a last step of the job migration.

Ref: #32567

/sig node
/cc @elieser1101 @kannon92 @haircommander

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

4 participants