Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Spyglass: Batch PR links" #23655

Merged
merged 2 commits into from
Sep 17, 2021
Merged

Conversation

chaodaiG
Copy link
Contributor

reverting #23647, it's caused tide down due to htmlUrl not recognized

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 17, 2021
@chaodaiG
Copy link
Contributor Author

/assign @chases2
/cc @YuviGold

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 17, 2021
@k8s-ci-robot
Copy link
Contributor

@chaodaiG: GitHub didn't allow me to request PR reviews from the following users: YuviGold.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/assign @chases2
/cc @YuviGold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/prow Issues or PRs related to prow area/prow/deck Issues or PRs related to prow's deck component approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow/tide Issues or PRs related to prow's tide component sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 17, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaodaiG, michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chases2
Copy link
Contributor

chases2 commented Sep 17, 2021

jsonPayload: {
component: "tide"
controller: "sync"
error: "Field 'htmlUrl' doesn't exist on type 'Actor'"
file: "prow/tide/tide.go:464"
func: "k8s.io/test-infra/prow/tide.(*Controller).query.func1"
level: "warning"
msg: "Failed to execute query."
query: "is:pr state:open archived:false label:"approved" label:"lgtm" -label:"do-not-merge" -label:"do-not-merge/hold" -label:"do-not-merge/invalid-owners-file" -label:"do-not-merge/work-in-progress" -label:"needs-rebase" org:"kubeflow""
}

@chases2 chases2 added the kind/oncall-hotlist Categorizes issue or PR as tracked by test-infra oncall. label Sep 17, 2021
@k8s-ci-robot k8s-ci-robot merged commit d8c100f into kubernetes:master Sep 17, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 17, 2021
@YuviGold
Copy link
Contributor

Sorry.
What tests could catch that? I think both UT and integration are using a fake GH client.

@chaodaiG
Copy link
Contributor Author

Sorry.
What tests could catch that? I think both UT and integration are using a fake GH client.

no worries. unfortunately there is no automated test for this, the only way we can catch this is probably read github docs :(

@chaodaiG chaodaiG deleted the revert branch September 29, 2021 22:06
@YuviGold
Copy link
Contributor

FYI a commit with tests is waiting on YuviGold@e62a284
Depends on shurcooL/githubv4#90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow/deck Issues or PRs related to prow's deck component area/prow/tide Issues or PRs related to prow's tide component area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/oncall-hotlist Categorizes issue or PR as tracked by test-infra oncall. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants