Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Scalability] Enable experimental Node Killer #17015

Merged
merged 1 commit into from
Mar 30, 2020
Merged

[Scalability] Enable experimental Node Killer #17015

merged 1 commit into from
Mar 30, 2020

Conversation

jprzychodzen
Copy link
Contributor

/sig scalability
Ref. kubernetes/perf-tests#1005
/assign @mm4tt

@k8s-ci-robot k8s-ci-robot added sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config labels Mar 30, 2020
@k8s-ci-robot k8s-ci-robot requested a review from mm4tt March 30, 2020 13:34
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Mar 30, 2020
@k8s-ci-robot k8s-ci-robot requested a review from shyamjvs March 30, 2020 13:34
mm4tt
mm4tt reviewed Mar 30, 2020
View reviewed changes
config/jobs/kubernetes/sig-scalability/sig-scalability-experimental-periodic-jobs.yaml
preset-service-account: "true"
preset-k8s-ssh: "true"
preset-e2e-scalability-common: "true"
spec:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add annotations with testGrid settings

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added. Thanks!

@jprzychodzen jprzychodzen force-pushed the enable-experimental-nk branch from 061e622 to b1c72c3 Compare March 30, 2020 14:01
mm4tt
mm4tt reviewed Mar 30, 2020
View reviewed changes
Copy link
Contributor

@mm4tt mm4tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 30, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jprzychodzen, mm4tt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2020
@jprzychodzen jprzychodzen force-pushed the enable-experimental-nk branch from b1c72c3 to 8311ab8 Compare March 30, 2020 14:48
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 30, 2020
@mm4tt
Copy link
Contributor

mm4tt commented Mar 30, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 30, 2020
@k8s-ci-robot k8s-ci-robot merged commit 8d34f14 into kubernetes:master Mar 30, 2020
@k8s-ci-robot
Copy link
Contributor

@jprzychodzen: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key sig-scalability-experimental-periodic-jobs.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-experimental-periodic-jobs.yaml

In response to this:

/sig scalability
Ref. kubernetes/perf-tests#1005
/assign @mm4tt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jprzychodzen jprzychodzen deleted the enable-experimental-nk branch March 31, 2020 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mm4tt mm4tt mm4tt left review comments

@shyamjvs shyamjvs Awaiting requested review from shyamjvs

Assignees

@mm4tt mm4tt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jprzychodzen @k8s-ci-robot @mm4tt