Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable PVs for kubemark jobs #16849

Merged

Conversation

maniSbindra
Copy link
Contributor

Currently PVs do not work on kube mark clusters due to reasons mentioned in the issue kubernetes/perf-tests#803 .

This change disables PVs for kubemark jobs. Please see conversation around this in the PR kubernetes/perf-tests#1125 (comment).

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 19, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @maniSbindra. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 19, 2020
@k8s-ci-robot k8s-ci-robot requested review from mborsz and wojtek-t March 19, 2020 11:32
@maniSbindra
Copy link
Contributor Author

/assign @mborsz

@maniSbindra
Copy link
Contributor Author

/assign @mm4tt

@mm4tt
Copy link
Contributor

mm4tt commented Mar 20, 2020

/ok-to-test

FTR, this change is no-op as currently CL2_ENABLE_PVS defaults to false. We're making this change because we want to change the default to true

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 20, 2020
@mm4tt
Copy link
Contributor

mm4tt commented Mar 26, 2020

Thanks, @maniSbindra !

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maniSbindra, mm4tt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2020
@k8s-ci-robot k8s-ci-robot merged commit 99176dd into kubernetes:master Mar 26, 2020
@k8s-ci-robot
Copy link
Contributor

@maniSbindra: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key sig-scalability-periodic-jobs.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-periodic-jobs.yaml

In response to this:

Currently PVs do not work on kube mark clusters due to reasons mentioned in the issue kubernetes/perf-tests#803 .

This change disables PVs for kubemark jobs. Please see conversation around this in the PR kubernetes/perf-tests#1125 (comment).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maniSbindra maniSbindra deleted the Disable-PVs-for-all-Kubemark-Jobs branch March 26, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants