-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable PVs for kubemark jobs #16849
Disable PVs for kubemark jobs #16849
Conversation
Hi @maniSbindra. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @mborsz |
/assign @mm4tt |
/ok-to-test FTR, this change is no-op as currently CL2_ENABLE_PVS defaults to false. We're making this change because we want to change the default to true |
config/jobs/kubernetes/sig-scalability/sig-scalability-periodic-jobs.yaml
Outdated
Show resolved
Hide resolved
config/jobs/kubernetes/sig-scalability/sig-scalability-periodic-jobs.yaml
Outdated
Show resolved
Hide resolved
Thanks, @maniSbindra ! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maniSbindra, mm4tt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@maniSbindra: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Currently PVs do not work on kube mark clusters due to reasons mentioned in the issue kubernetes/perf-tests#803 .
This change disables PVs for kubemark jobs. Please see conversation around this in the PR kubernetes/perf-tests#1125 (comment).