-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make high-density job use forked density config #16162
Conversation
/assign @wojtek-t |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mm4tt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -315,15 +315,11 @@ periodics: | |||
- --test-cmd-args=--nodes=600 | |||
- --test-cmd-args=--provider=kubemark | |||
- --test-cmd-args=--report-dir=/workspace/_artifacts | |||
- --test-cmd-args=--testconfig=testing/density/config.yaml | |||
# TODO(https://github.com/kubernetes/perf-tests/issues/1007): load test should be used to test high-density. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you're touching it - can you also open an issue to setup regular GCE high-density test (so that we not only have kubemark)?
[I guess we may need bigger nodes or sth, that's why we shouldn't do that in this PR]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done - kubernetes/perf-tests#1028
/lgtm |
/hold cancel |
@mm4tt: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Ref. kubernetes/perf-tests#1007
/hold
Wait for kubernetes/perf-tests#1026