Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go.mod: Update sigs.k8s.io/promo-tools/v3 to v3.2.1 #2255

Merged
merged 2 commits into from
Sep 15, 2021
Merged

go.mod: Update sigs.k8s.io/promo-tools/v3 to v3.2.1 #2255

merged 2 commits into from
Sep 15, 2021

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Sep 15, 2021 •
edited
Loading

What type of PR is this?

/kind cleanup documentation
/area dependency

What this PR does / why we need it:

  • go.mod: Update sigs.k8s.io/promo-tools/v3 to v3.2.1
    ...which fixes import issues following the repo rename.
  • README.md: Update references to promotion tooling repo

Signed-off-by: Stephen Augustus [email protected]

Which issue(s) this PR fixes:

Special notes for your reviewer:

Doc updates inbound as well.

Does this PR introduce a user-facing change?

- go.mod: Update sigs.k8s.io/promo-tools/v3 to v3.2.1
  ...which fixes import issues following the [repo rename](https://github.com/kubernetes-sigs/promo-tools/issues/424).

@justaugustus
go.mod: Update sigs.k8s.io/promo-tools/v3 to v3.2.1
faed630 
...which fixes import issues following the repo rename.

Signed-off-by: Stephen Augustus <[email protected]>
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 15, 2021
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 15, 2021
@justaugustus justaugustus changed the title [WIP] go.mod: Update sigs.k8s.io/promo-tools/v3 to v3.2.1 go.mod: Update sigs.k8s.io/promo-tools/v3 to v3.2.1 Sep 15, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 15, 2021
@justaugustus
Copy link
Member Author

/assign @puerco @cpanato @Verolop @ameukam
cc: @kubernetes/release-engineering

@puerco
Copy link
Member

puerco commented Sep 15, 2021

Let's gooo 🚀
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2021
@k8s-ci-robot k8s-ci-robot merged commit 10d91c3 into kubernetes:master Sep 15, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 15, 2021
@justaugustus justaugustus mentioned this pull request Sep 15, 2021
Closed
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkorbi mkorbi Awaiting requested review from mkorbi

@puerco puerco Awaiting requested review from puerco

Assignees

@Verolop Verolop

@ameukam ameukam

@puerco puerco

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
6 participants
@justaugustus @k8s-ci-robot @puerco @Verolop @ameukam @cpanato