Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add terminated watches metrics #2194

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Add terminated watches metrics #2194

merged 1 commit into from
Nov 15, 2022

Conversation

bouaouda-achraf
Copy link
Contributor

@bouaouda-achraf bouaouda-achraf commented Nov 13, 2022 •
edited
Loading

/kind feature

This PR adds a new Prometheus-based measurement that counts the closed watchers.
Linked with #2054
/assign @marseel @wojtek-t

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 13, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 13, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: bouaouda-achraf / name: ACHRAF BOUAOUDA (5fe6e4a)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 13, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @bouaouda-achraf!

It looks like this is your first PR to kubernetes/perf-tests 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/perf-tests has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @bouaouda-achraf. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 13, 2022
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 13, 2022
@marseel
Copy link
Member

marseel commented Nov 14, 2022

Could you review it please?
/assign @tosi3k

@tosi3k
Copy link
Member

tosi3k commented Nov 14, 2022

Please also change the PR's title to better reflect the changes we're doing here.

@bouaouda-achraf bouaouda-achraf changed the title add Watcher Performance Add terminated watches metrics Nov 14, 2022
@bouaouda-achraf
Copy link
Contributor Author

@tosi3k thank you for your reviews, I fixed all your comments.

@bouaouda-achraf bouaouda-achraf requested review from tosi3k and removed request for wojtek-t and krzysied November 14, 2022 22:45
tosi3k
tosi3k suggested changes Nov 15, 2022
View reviewed changes
clusterloader2/testing/load/modules/measurements.yaml
- name: Watch connections terminated by the kube-apiserver
query: sum(increase(apiserver_terminated_watchers_total[%v:])) by (resource)
- name: Watch connections reinitialized by the kube-apiserver
query: sum(increase(apiserver_watch_cache_initializations_total[%v:])) by (resource)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we split the second query into a separate measurement (but under the same {{if $ENABLE_TERMINATED_WATCHES_MEASUREMENT}} branch) with different Identifier and metricName, say WatchCacheInitializations and Watch Cache Initializations, respectively?

Sorry for the late notice about this, I realized it just won't look nice in https://perf-dash.k8s.io/ after we enable it by default in our tests.

clusterloader2/testing/load/modules/measurements.yaml Outdated Show resolved Hide resolved
clusterloader2/testing/load/modules/measurements.yaml Outdated
queries:
- name: Watch connections terminated by the kube-apiserver
query: sum(increase(apiserver_terminated_watchers_total[%v:])) by (resource)
- name: Watch connections reinitialized by the kube-apiserver
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: let's shorten the description to just Watch cache reinitializations.

@tosi3k
Copy link
Member

tosi3k commented Nov 15, 2022

Last minor ask - please squash the commits and we're good to go :).

@bouaouda-achraf
Copy link
Contributor Author

@tosi3k commits squashed and forked branch rebased with the last commit.
thank you so much for your help :)

@tosi3k
Copy link
Member

tosi3k commented Nov 15, 2022

/ok-to-test
/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 15, 2022
@marseel
Copy link
Member

marseel commented Nov 15, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bouaouda-achraf, marseel, tosi3k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2022
@k8s-ci-robot k8s-ci-robot merged commit e34ac54 into kubernetes:master Nov 15, 2022
@bouaouda-achraf bouaouda-achraf mentioned this pull request Oct 8, 2024
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tosi3k tosi3k Awaiting requested review from tosi3k

Assignees

@marseel marseel

@wojtek-t wojtek-t

@tosi3k tosi3k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bouaouda-achraf @k8s-ci-robot @marseel @tosi3k @wojtek-t