Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create team directory for provider-gcp and update group members #5327

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Create team directory for provider-gcp and update group members #5327

merged 1 commit into from
Jan 23, 2025
+40 −24

Conversation

mmamczur
Copy link
Contributor

@mmamczur mmamczur commented Jan 7, 2025 •
edited
Loading

Create team directory for provider-gcp and move cloud-provider-gcp-* groups there.

Also:

  • remove @sdmodi who left the GKE team.
  • add @mmamczur, member of the team that owns service controller part of cloupd-provider-gcp
  • update OWNER_ALIASES, add a few people as OWNERS, remove @abgworrall since he is no longer at Google

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/github-management Issues or PRs related to GitHub Management subproject labels Jan 7, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 7, 2025
@mmamczur mmamczur force-pushed the patch-1 branch 2 times, most recently from 83ebeee to 46245d9 Compare January 7, 2025 09:35
@mmamczur
Copy link
Contributor Author

mmamczur commented Jan 7, 2025

/assign @bowei

bowei
bowei reviewed Jan 7, 2025
View reviewed changes
config/kubernetes/org.yaml Outdated
@@ -1351,8 +1351,8 @@ teams:
- cici37
- jpbetz
- jprzychodzen
- mmamczur
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to split this into its own folder like what the other cloud providers did:

https://github.com/kubernetes/org/tree/main/config/kubernetes/provider-azure

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have a good way to set OWNERS files on this entire file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be great. Once you split off to a subdirectory, you wouldn't need org admins to approve PRs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the PR. I'm not sure if it done correctly so please take a look if anything is missing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@palnabarun would you be able to approve this change? I'm not sure who I can ask to merge this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. You are all set! Thank you for the refactor. Really appreciate it.

@mmamczur
Create team directory for provider-gcp and move cloud-provider-gcp-* …
aab5b53 
…groups there.

Also:
- remove sdmodi who left the GKE team.
- add mmamczur, member of the team that owns service controller part of cloupd-provider-gcp
- update OWNER_ALIASES, add a few people as OWNERS, remove abgworrall since he is no longer at Google
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 10, 2025
@mmamczur mmamczur changed the title Update members of cloud-provider-gcp-maintainers Create team directory for provider-gcp and update group members Jan 10, 2025
@bowei
Copy link
Member

bowei commented Jan 13, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 13, 2025
palnabarun
palnabarun approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@palnabarun palnabarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mmamczur, palnabarun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2025
@k8s-ci-robot k8s-ci-robot merged commit db89f33 into kubernetes:main Jan 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palnabarun palnabarun palnabarun approved these changes

@bowei bowei bowei left review comments

@MadhavJivrajani MadhavJivrajani Awaiting requested review from MadhavJivrajani

Assignees

@bowei bowei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmamczur @bowei @k8s-ci-robot @palnabarun