Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 1.33 release team permissions #5324

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Add 1.33 release team permissions #5324

merged 1 commit into from
Jan 8, 2025
+22 −49

Conversation

npolshakova
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 3, 2025
@k8s-ci-robot k8s-ci-robot added area/github-management Issues or PRs related to GitHub Management subproject sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 3, 2025
@npolshakova npolshakova mentioned this pull request Jan 3, 2025
Open
@katcosgrove
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2025
Vyom-Yadav
Vyom-Yadav reviewed Jan 4, 2025
View reviewed changes
Copy link
Member

@Vyom-Yadav Vyom-Yadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments (added as you still have to sort the list (CI))

config/kubernetes/sig-release/teams.yaml Outdated Show resolved Hide resolved
config/kubernetes/sig-release/teams.yaml Outdated Show resolved Hide resolved
@npolshakova npolshakova force-pushed the update-1-33-team-leads branch from 8c937c9 to f51d9c6 Compare January 8, 2025 20:39
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2025
@npolshakova npolshakova requested a review from Vyom-Yadav January 8, 2025 20:40
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gracenng, npolshakova

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2025
@gracenng
Copy link
Member

gracenng commented Jan 8, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2025
@k8s-ci-robot k8s-ci-robot merged commit 0db523a into kubernetes:main Jan 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gracenng gracenng gracenng approved these changes

@katcosgrove katcosgrove Awaiting requested review from katcosgrove

@xmudrii xmudrii Awaiting requested review from xmudrii

@Vyom-Yadav Vyom-Yadav Awaiting requested review from Vyom-Yadav

Assignees

@katcosgrove katcosgrove

@gracenng gracenng

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@npolshakova @katcosgrove @k8s-ci-robot @gracenng @Vyom-Yadav