-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cjihrig to javascript-admins #5322
Conversation
Welcome @cjihrig! |
Hi @cjihrig. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Approved from my perspective as an existing admin. This will enable @cjihrig to approve PRs for testing and other useful administrative tasks. |
/ok-to-test |
@cjihrig small comment: can you please remove the reference to the PR from your commit message? |
This commit adds myself to the javascript-admin team and removes davidgamero as requested.
@palnabarun done. Just out of curiosity, why should we not link to PRs/issues/comments? |
friendly ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjihrig, palnabarun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@cjihrig -- we don't usually @ things in commits because it triggers notifications and events. |
@cjihrig you can probably ref the PR in the conversation here instead of the commit message to avoid that |
This commit adds myself to the javascript-admin team and removes davidgamero as requested in
kubernetes-client/javascript#2129 (comment)
cc: @brendandburns @davidgamero