Annotations: Allow @ in URLs.

[pando85]

The same as #11739, we need to allow those kinds of configurations in case your group names contain your domain separated by an at symbol.

What this PR does / why we need it:

To allow group names that contain the domain.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• CVE Report (Scanner found CVE and adding report)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added unit and/or e2e tests to cover my changes.
• All new and existing tests passed.

[k8s-ci-robot]

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

Welcome @pando85!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @pando85. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name	Link
🔨 Latest commit	be50c80
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/677d343a28e4660008d7e749

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pando85
Once this PR has been reviewed and has the lgtm label, please assign cpanato for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Gacko]

Please review your change, CI / test-go is failing for it.

[pando85]

Please review your change, CI / test-go is failing for it.

Do you think it is related with my change? I ran it in local and I have the same result with this commit and with the previous one.

[pando85]

I just rebase main again to see if that fixes the problem.

[Gacko]

Have you git clean -xfd your repository? Make sure there are no leftovers from main branch and update your local branch.

[pando85]

I found the error. I added the test in the same place as #11739 but that was not checking the correct parser.

I didn't find any test for URLWithNginxVariableRegex but I checked that the current change should fix the problem that I described.

I will amend the commit removing the wrong lines that I added to the unit tests.

[Gacko]

Adding a test is not about proving your change works, it's about ensuring it keeps working with future changes. So I'd ask you to add a test.

[pando85]

Adding a test is not about proving your change works, it's about ensuring it keeps working with future changes. So I'd ask you to add a test.

Oh yes, I agree with that. I probably didn't communicate it well. Let's try again.

Could you point me to the current tests related to those validators? I cannot find them.

Also, PR #11882, which is pretty similar to this one, added one useless test. It isn't testing the behavior, indeed you can revert the change in validators.go and the tests still pass with that new test added.