Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mixed Protocol for NetLB IPv4 #2779

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Mixed Protocol for NetLB IPv4 #2779

merged 1 commit into from
Jan 13, 2025

Conversation

TortillaZHawaii
Copy link
Contributor

  1. Uses previously created forwardingrules.MixedManagerNetLB in pkg/loadbalancers/l4netlb.go
  2. Adds tests for creating, deleting and transitions between TCP, UDP and mixed protocol IPv4 NetLBs pkg/loadbalancers/l4netlb_mixed_test.go. Those tests are similar to the already existing ILB mixed protocol testing suite at pkg/loadbalancers/l4_mixed_test.go.
  3. Refactored helpers for the mixed tests to separate common code (pkg/loadbalancers/mixedprotocoltest/) from the ilb (mixedprotocolilbtest) and netlb (mixedprotocolnetlbtest) specfic.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 3, 2025
@k8s-ci-robot k8s-ci-robot requested review from aojea and sawsa307 January 3, 2025 17:30
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 3, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @TortillaZHawaii. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 3, 2025
@TortillaZHawaii
Copy link
Contributor Author

Commits will be squashed after LGTM and potential fixes.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2025
@TortillaZHawaii TortillaZHawaii marked this pull request as ready for review January 7, 2025 12:10
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 7, 2025
@TortillaZHawaii
Copy link
Contributor Author

/assign @mmamczur

@TortillaZHawaii TortillaZHawaii mentioned this pull request Jan 7, 2025
Closed
@TortillaZHawaii
Copy link
Contributor Author

/lint

k8s-ci-robot
k8s-ci-robot reviewed Jan 9, 2025
View reviewed changes
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TortillaZHawaii: 3 warnings.

In response to this:

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

pkg/loadbalancers/mixedprotocoltest/mixedprotocolilbtest/ips.go Outdated Show resolved Hide resolved
pkg/loadbalancers/mixedprotocoltest/resources.go Show resolved Hide resolved
pkg/loadbalancers/mixedprotocoltest/mixedprotocolnetlbtest/ips.go Outdated Show resolved Hide resolved
@TortillaZHawaii
Copy link
Contributor Author

/lint

k8s-ci-robot
k8s-ci-robot reviewed Jan 9, 2025
View reviewed changes
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TortillaZHawaii: 0 warnings.

In response to this:

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mmamczur
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 13, 2025
@TortillaZHawaii
Update existing L4NetLB to use MixedNetLBManager
f82c060 
This makes it possible to create mixed protocol (both TCP and UDP) external IPv4 loadbalancers. This commit:
1. Uses previously created `forwardingrules.MixedManagerNetLB` in pkg/loadbalancers/l4netlb.go
2. Adds tests for creating, deleting and transitions between TCP, UDP and mixed protocol IPv4 NetLBs pkg/loadbalancers/l4netlb_mixed_test.go. Those tests are similar to the already existing ILB mixed protocol testing suite at pkg/loadbalancers/l4_mixed_test.go.
3. Refactored helpers for the mixed tests to separate common code (pkg/loadbalancers/mixedprotocoltest/) from the ilb (mixedprotocolilbtest) and netlb (mixedprotocolnetlbtest) specfic.
@TortillaZHawaii TortillaZHawaii force-pushed the dwysocki-netlb-ipv4-merge branch from 8f43a43 to f82c060 Compare January 13, 2025 14:39
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 13, 2025
@mmamczur
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 13, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mmamczur, TortillaZHawaii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TortillaZHawaii
Copy link
Contributor Author

/unhold

Commits are squashed.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2025
@k8s-ci-robot k8s-ci-robot merged commit 84e6562 into kubernetes:master Jan 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k8s-ci-robot k8s-ci-robot k8s-ci-robot left review comments

@aojea aojea Awaiting requested review from aojea

@sawsa307 sawsa307 Awaiting requested review from sawsa307

Assignees

@mmamczur mmamczur

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TortillaZHawaii @k8s-ci-robot @mmamczur