Add multiproject manager which will be responsible for starting and tracking controllers per ProviderConfig #2762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
panslava
force-pushed
the
multi-project-manager
branch
from
2da2971 to
5a6457c
Compare
k8s-ci-robot
removed
the
needs-rebase
panslava
force-pushed
the
multi-project-manager
branch
2 times, most recently
from
4ec70b4 to
e2a19f4
Compare
k8s-ci-robot
added
the
needs-rebase
panslava
force-pushed
the
multi-project-manager
branch
from
e2a19f4 to
0264293
Compare
k8s-ci-robot
added
size/L
pkg/multiproject/manager/manager.go
Outdated
| } | ||
| negControllerStopCh, err := neg.StartNEGController(cscm.informersFactory, cscm.kubeClient, cscm.svcNegClient, cscm.eventRecorderClient, cscm.kubeSystemUID, cscm.clusterNamer, cscm.l4Namer, cscm.lpConfig, cscm.defaultCloudConfig, cscm.globalStopCh, cscm.logger, cs) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to start NEG controller for project %s: %v", csKey, err) |
There was a problem hiding this comment.
IF the StartNEGController call fails, do we expect the caller of StartControllersForProviderConfig to trigger removal of finalizer?
There was a problem hiding this comment.
I think it's better to attempt cleaning finalizer inside this function in case of an error
Added this, thanks for the suggestion
pkg/multiproject/manager/manager.go
Outdated
|
|
||
| type ProviderConfigControllersManager struct { | ||
| controllers map[string]*ControllerSet | ||
| mu sync.Mutex |
There was a problem hiding this comment.
nit: Let's use a mutex hat for the variables we want this mutex to control
panslava
force-pushed
the
multi-project-manager
branch
from
0264293 to
ff66158
Compare
panslava
changed the title
panslava
force-pushed
the
multi-project-manager
branch
3 times, most recently
from
eee8537 to
2f1d13d
Compare
|
ready for rereview @gauravkghildiyal |
|
/lgtm |
k8s-ci-robot
added
do-not-merge/hold
panslava
force-pushed
the
multi-project-manager
branch
from
2f1d13d to
db1b624
Compare
k8s-ci-robot
removed
the
lgtm
panslava
force-pushed
the
multi-project-manager
branch
2 times, most recently
from
8eefd79 to
8e9fa98
Compare
…racking controllers per ClusterSlice
panslava
force-pushed
the
multi-project-manager
branch
from
8e9fa98 to
7b20d53
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauravkghildiyal, panslava The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/assign @gauravkghildiyal
based on 3 previous prs