Do not load secret from Ingress spec if provided name is empty

kubernetes · Apr 30, 2019 · 66fd3b6 · 66fd3b6
1 parent d84515a
commit 66fd3b6
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/pkg/tls/tls.go b/pkg/tls/tls.go
@@ -59,6 +59,9 @@ func (t *TLSCertsFromSecretsLoader) Load(ing *extensions.Ingress) ([]*loadbalanc
 	var certs []*loadbalancers.TLSCerts
 
 	for _, tlsSecret := range ing.Spec.TLS {
+		if tlsSecret.SecretName == "" {
+			continue
+		}
 		// TODO: Replace this for a secret watcher.
 		glog.V(3).Infof("Retrieving secret for ing %v with name %v", ing.Name, tlsSecret.SecretName)
 		secret, err := t.Client.Core().Secrets(ing.Namespace).Get(tlsSecret.SecretName, meta_v1.GetOptions{})