-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update e2e test images, fix test timeouts #651
Conversation
Hi @dereknola. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@DamianSawicki Can you approve this for "testing". Hopefully this should help resolve the prow test failures. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pull-kubernetes-dns-test
succeeded! 🎉🎉🎉 Thanks so much @dereknola for fixing it and thereby unblocking other PRs!
Btw. how did you know that bumping hyperkube
and etcd
images would help?
I didn't, but it was the starting point for trying to fix stuff. Those images are horribly out of date, so bumping to latest versions would bring this repo in line with the rest of the K8s packages. I figured there might be some compatibility issues affecting the tests. |
@DamianSawicki I have bumped the related images as much as possible and left TODOs in areas that need future work. |
@@ -13,11 +13,11 @@ | |||
# limitations under the License. | |||
# | |||
# Builds the docker container for the e2e test. | |||
FROM registry.k8s.io/kube-dnsmasq-amd64:1.14.11 | |||
FROM alpine:3.20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original image of kube-dnsmasq-amd64:1.4.1
was just alpine with dnsmasq added. Since that image is no longer built, replicating it with normal alpine works just fine.
All this image does is exec the side-car
binary and watches dnsmasq
Yeah, let's leave it to separate PRs. Thanks again for fixing the CI for kubernetes/dns! /lgtm |
One more thing, please squash all these commits before merging with EDIT: as @kl52752 pointed out to me on priv, PRs in this repo used to always auto-merge, so there won't be time to use the button |
Thank you for your commit @dereknola :) |
Update side-e2e base image and k8s-dns-dnsmasq images to maximum allowed Signed-off-by: Derek Nola <[email protected]>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DamianSawicki, dereknola, kl52752 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I guess it's the @k8s-ci-robot that is merging PRs in this repo, and not the native github auto-merge feature. It seems we can prevent it from doing so with the |
Changes
Linked Issues
#646