Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add self to sig-instrumentation maintainers #8148

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

richabanker
Copy link
Contributor

@richabanker richabanker commented Nov 13, 2024

Issue: #8149

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 13, 2024
@k8s-ci-robot k8s-ci-robot added the sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. label Nov 13, 2024
@dashpole
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2024
Copy link
Member

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@cblecker
Copy link
Member

Hello @richabanker!

Is there a link to the email to the dev@ list where consensus on this was achieved? I also don't see a leadership change issue related to this. I'd suggest opening one up (https://github.com/kubernetes/community/issues/new/choose) as it has a whole checklist of things you need, and can help you step through the process of changing a SIG leadership position.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2024
@richabanker
Copy link
Contributor Author

@cblecker here's the link to the email thread. We opened #8149, I'll start going through the list now.

@cblecker
Copy link
Member

@richabanker It looks like that thread went out to the sig instrumentation list, but not the main dev@ list (which is one of the requirements).

Thank you opening that issue! If you have questions as you run through the list, please feel free to reach out to either SIG ContribEx or the Steering Committee for assistance.

@richabanker richabanker mentioned this pull request Nov 18, 2024
17 tasks
@richabanker
Copy link
Contributor Author

@cblecker The email was now forwarded to the dev@ list, link, does that suffice for this PR to be merged?

@BenTheElder
Copy link
Member

I think the intention is to have at least a week for any comments after sending it out to everyone? Probably best to give it a few days to clearly achieve that.

While we're waiting for that decision, can you set the new email field on your entry? Thanks!

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2024
@richabanker
Copy link
Contributor Author

I think the intention is to have at least a week for any comments after sending it out to everyone? Probably best to give it a few days to clearly achieve that.

Ah that makes sense, thanks!
Also, added my email now.

@rexagod
Copy link
Member

rexagod commented Nov 21, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 3, 2024
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 3, 2024
@richabanker
Copy link
Contributor Author

@cblecker are we ok to merge this now?

@BenTheElder
Copy link
Member

https://groups.google.com/a/kubernetes.io/g/dev/c/UMZ6c_gBtzc/m/LD0TEqsmBgAJ was forwarded to [email protected] november 18th, 2.5 weeks ago.

/lgtm
/approve
/hold

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dashpole, logicalhan, rexagod, richabanker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2024
@richabanker
Copy link
Contributor Author

@BenTheElder are we good to unhold this now?

@BenTheElder
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit 11a1498 into kubernetes:master Dec 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants