Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SIG Docs Arabic team meeting to README #7752

Closed
wants to merge 6 commits into from
Closed

Add SIG Docs Arabic team meeting to README #7752

wants to merge 6 commits into from

Conversation

adowair
Copy link

@adowair adowair commented Mar 12, 2024

This commit will add details of the Arabic localization team's regular meeting to the SIG Docs README. This meeting was setup at the request of the team. Find the starting conversation here: https://kubernetes.slack.com/archives/C0191RDKHU1/p1706210213318239

Which issue(s) this PR fixes:
None

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 12, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @adowair!

It looks like this is your first PR to kubernetes/community 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/community has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @adowair. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 12, 2024
@cblecker
Copy link
Member

This change needs to be made in sigs.yaml and make run

@cblecker
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adowair
Once this PR has been reviewed and has the lgtm label, please assign bentheelder for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 12, 2024
@adowair
Copy link
Author

adowair commented Mar 12, 2024

/retest-required

@cblecker cblecker added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 12, 2024
a-mccarthy
a-mccarthy reviewed Mar 14, 2024
View reviewed changes
sigs.yaml Outdated Show resolved Hide resolved
@adowair adowair mentioned this pull request Mar 16, 2024
Closed
9 tasks
@adowair
Copy link
Author

adowair commented Mar 31, 2024

Hi @a-mccarthy, is there anything else we need to review+merge this PR? Thank you bunches

divya-mohan0209
divya-mohan0209 suggested changes Apr 1, 2024
View reviewed changes
sig-docs/README.md Show resolved Hide resolved
@adowair adowair requested a review from divya-mohan0209 April 3, 2024 17:39
@adowair
Copy link
Author

adowair commented May 10, 2024

Bumping this PR 😄, thank you for the reviews

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 14, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

divya-mohan0209
divya-mohan0209 reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs a rebase, @adowair . Once the changes are done, happy to lgtm

adowair added 2 commits May 15, 2024 21:57
@adowair
Add SIG Docs Arabic team meeting to README
38b5a33 
This commit will add details of the Arabic localization team's
regular meeting to the SIG Docs README. This meeting was setup
at the request of the team. Find the starting conversation here:
https://kubernetes.slack.com/archives/C0191RDKHU1/p1706210213318239

Signed-off-by: Ali Dowair <[email protected]>
@adowair
Revert "Add SIG Docs Arabic team meeting to README"
cfcddf8 
This reverts commit f065557.
adowair added 4 commits May 15, 2024 21:57
@adowair
Generate entry from sigs.yaml
7e6d15b 
This commit will generate the required information properly, by
editing the sig.yaml file and running make, instead of editing
sid-docs/README.md directly.

Signed-off-by: Ali Dowair <[email protected]>
@adowair
Fix meeting time 16:00 -> 18:00
45c1dfc 
This commit will correct the PR to match the actual meeting. This
is purely due to a user error on my end.

Signed-off-by: Ali Dowair <[email protected]>
@adowair
Fix typo in a URL
baf37d5 
This commit remooves and extraneous letter from a URL.

Signed-off-by: Ali Dowair <[email protected]>
@adowair
Adjust meeting 18:00 biweekly -> 17:00 weekly
1e6812e 
This commit adjusts the meeting details to reflect the new
meeting time, which was agreed upon in the following thread.

Slack: https://kubernetes.slack.com/archives/CP9FKRD51/p1711479879459149?thread_ts=1710277893.188959&cid=CP9FKRD51
Signed-off-by: Ali Dowair <[email protected]>
@adowair adowair force-pushed the sig-docs-arabic-team-meeting branch from 43b6114 to 1e6812e Compare May 15, 2024 18:58
@adowair
Copy link
Author

adowair commented May 15, 2024

This PR needs a rebase, @adowair . Once the changes are done, happy to lgtm

Thank you @divya-mohan0209, I've gone ahead and rebased

@k8s-ci-robot
Copy link
Contributor

@adowair: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-community-verify 1e6812e link true /test pull-community-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 14, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@adowair adowair mentioned this pull request Aug 2, 2024
Open
@adowair
Copy link
Author

adowair commented Aug 2, 2024

This PR is superseded by #8003.

@adowair adowair closed this Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divya-mohan0209 divya-mohan0209 divya-mohan0209 requested changes

@a-mccarthy a-mccarthy a-mccarthy left review comments

@reylejano reylejano Awaiting requested review from reylejano

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adowair @k8s-ci-robot @cblecker @a-mccarthy @divya-mohan0209