chore: replace deprecated NewIndexerInformer #7727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Omer Aplatony <[email protected]>
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
the
size/M
|
/retest |
|
/milestone vertical-pod-autoscaler-1.4.0 |
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
Signed-off-by: Omer Aplatony <[email protected]>
|
Ping @adrianmoisey |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm thanks! |
k8s-ci-robot
added
the
lgtm
raywainman
reviewed
Jan 31, 2025
| store, controller := cache.NewInformerWithOptions(informerOptions) | ||
| indexer, ok := store.(cache.Indexer) | ||
| if !ok { | ||
| klog.ErrorS(nil, "Expected Indexer, but got a Store that does not implement Indexer") |
There was a problem hiding this comment.
Can we use klog.Fatal here instead?
There was a problem hiding this comment.
I prefer to use klog.ErrorS + os.Exit . Please take a look at: kubernetes/klog#416
|
/lgtm /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: omerap12, raywainman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
NewIndexerInformeris deprecated, this PR replace it by usingNewInformerWithOptionsinsteadWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: