Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging: Start from a capital letter #7670

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

ialidzhikov
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

From sig-instrumentation's Logging guide: "Start from a capital letter."

Right now some log entries start with a capital letter, other don't:

2025-01-07 14:12:37	{"log":"Simulating node foo removal","pid":"1","severity":"INFO","source":"cluster.go:156"}
2025-01-07 14:12:37	{"log":"Node foo - cpu requested is 6.1809% of allocatable","pid":"1","severity":"INFO","source":"klogx.go:87"}
2025-01-07 14:12:37	{"log":"Node foo is underutilized: cpu requested (6.1809% of allocatable) is below the scale-down utilization threshold","pid":"1","severity":"INFO","source":"eligibility.go:167"}
2025-01-07 14:12:27	{"log":"node foo may be removed","pid":"1","severity":"INFO","source":"cluster.go:174"}

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 7, 2025
@k8s-ci-robot k8s-ci-robot requested a review from feiskyer January 7, 2025 15:52
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 7, 2025
@Shubham82
Copy link
Contributor

Thanks, @ialidzhikov for this PR.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2025
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2025
@k8s-ci-robot k8s-ci-robot merged commit 5cd491a into kubernetes:master Jan 9, 2025
6 checks passed
@ialidzhikov ialidzhikov deleted the nit/logging branch January 10, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants