Improve kind cluster creation with proper error handling and version check #7666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…check Signed-off-by: Omer Aplatony <[email protected]>
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
area/vertical-pod-autoscaler
size/XS
|
running tests locally. |
k8s-ci-robot
added
the
do-not-merge/hold
|
Works: • [185.160 seconds]
------------------------------
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS
------------------------------
[SynchronizedAfterSuite]
/Users/omera/Desktop/PersonlRepos/autoscaler/vertical-pod-autoscaler/e2e/v1/e2e.go:75
I0107 12:49:45.001823 18417 e2e.go:295] Running AfterSuite actions on all nodes
I0107 12:49:45.001964 18417 e2e.go:301] Running AfterSuite actions on node 1
I0107 12:49:45.002009 18417 util.go:612] Skipping dumping logs from cluster
[SynchronizedAfterSuite] PASSED [0.000 seconds]
------------------------------
[ReportAfterSuite] Kubernetes e2e JUnit report
/Users/omera/go/pkg/mod/k8s.io/[email protected]/test/e2e/framework/test_context.go:615
[ReportAfterSuite] PASSED [0.005 seconds]
------------------------------
Ran 5 of 398 Specs in 1833.912 seconds
SUCCESS! -- 5 Passed | 0 Failed | 0 Pending | 393 Skipped
--- PASS: TestE2E (1833.92s)
PASS
ok command-line-arguments 1835.098s
~/Desktop/PersonlRepos/autoscaler/vertical-pod-autoscaler/hack
v1beta2 test result: 1
Please check v1beta2 "go test" logs!
v1 test result: 0
Tests failed/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm Thanks! |
k8s-ci-robot
added
the
lgtm
|
/approve Thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: omerap12, voelzmo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Updates kind cluster version.
Enhances kind cluster creation by implementing proper error handling and version checking. Previously, the script would continue execution even if cluster creation failed. This PR addresses that issue by adding appropriate error handling.
Which issue(s) this PR fixes:
Fixes #7662
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: