Replace deprecated NewIndexerInformer and fix stopCh handling

[omerap12]

What type of PR is this?

/kind cleanup
/kind bug

What this PR does / why we need it:

Replace deprecated NewIndexerInformer with NewInformerWithOptions and implements proper stop channel handling in informers. This change improves resource cleanup and follows current Kubernetes best practices for informer lifecycle management.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

This PR focuses on two main changes:

1. Replaces all instances of deprecated NewIndexerInformer with NewInformerWithOptions
2. Implements proper stop channel handling to prevent goroutine leaks

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: omerap12
Once this PR has been reviewed and has the lgtm label, please assign kwiesmueller for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• vertical-pod-autoscaler/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[omerap12]

/retest

[k8s-ci-robot]

@omerap12: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubernetes-e2e-autoscaling-vpa-full	d0a6d17	link	false	/test pull-kubernetes-e2e-autoscaling-vpa-full

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[omerap12]

I will split this PR into two. I'm currently facing an issue with the indexer, but I want to ensure that the channel bug fix is included in the new release.
/close

[k8s-ci-robot]

@omerap12: Closed this PR.

In response to this:

I will split this PR into two. I'm currently facing an issue with the indexer, but I want to ensure that the channel bug fix is included in the new release.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.