Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VPA: Add docs about AKS and EKS with Cilium #7655

Merged
merged 2 commits into from
Jan 8, 2025
Merged

VPA: Add docs about AKS and EKS with Cilium #7655

merged 2 commits into from
Jan 8, 2025

Conversation

adrianmoisey
Copy link
Member

Ref:

What type of PR is this?

/kind documentation

What this PR does / why we need it:

More docs to help users

Which issue(s) this PR fixes:

Fixes #6915

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. area/vertical-pod-autoscaler labels Jan 5, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 5, 2025
voelzmo
voelzmo suggested changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@voelzmo voelzmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just a few wording suggestions from my side.

vertical-pod-autoscaler/docs/faq.md Outdated Show resolved Hide resolved
vertical-pod-autoscaler/docs/faq.md Outdated Show resolved Hide resolved
vertical-pod-autoscaler/docs/faq.md Outdated Show resolved Hide resolved
vertical-pod-autoscaler/docs/faq.md Outdated Show resolved Hide resolved
@adrianmoisey
Copy link
Member Author

Thanks for the review, I've made those suggested changed. Can you take another look?

@voelzmo
Copy link
Contributor

voelzmo commented Jan 8, 2025

Thanks!
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianmoisey, voelzmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

omerap12
omerap12 reviewed Jan 8, 2025
View reviewed changes
Copy link
Member

@omerap12 omerap12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2025
@k8s-ci-robot k8s-ci-robot merged commit 83b693c into kubernetes:master Jan 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omerap12 omerap12 omerap12 left review comments

@voelzmo voelzmo voelzmo approved these changes

@krzysied krzysied Awaiting requested review from krzysied

Assignees

@omerap12 omerap12

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vertical Pod Autoscaler is not recreating pods at runtime
4 participants
@adrianmoisey @voelzmo @k8s-ci-robot @omerap12