Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MinIO for Azure deprecation deployment warning + pinning LKG release #341

Merged

Conversation

marosset
Copy link
Contributor

@marosset marosset commented Dec 9, 2024

MinIO gateway was deprecated in 2022 and the functionality is no longer available in minio/minio:latest images.

This PR updates docs for deploying PROW on Azure to bring attention to this and also references the LKG container image that still containers this functionality.

Deprecation notice - https://blog.min.io/deprecation-of-the-minio-gateway/

Last known release docs - https://github.com/minio/minio/blob/RELEASE.2022-04-29T01-27-09Z/docs/gateway/azure.md

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 9, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 9, 2024
Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for k8s-prow ready!

Name Link
🔨 Latest commit 4f82c68
🔍 Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/675769dca4e3e700085c8c0d
😎 Deploy Preview https://deploy-preview-341--k8s-prow.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@marosset
Copy link
Contributor Author

marosset commented Dec 9, 2024

starter-azure.yaml updates in kubernetes/test-infra#33919

@smg247
Copy link
Contributor

smg247 commented Dec 9, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2024
@smg247
Copy link
Contributor

smg247 commented Dec 9, 2024

Lint is failing though:

./site/content/en/docs/getting-started-deploy.md:281:91: "Feburary" is a misspelling of "February"
ERROR: bad spelling, fix with hack/update/misspell.sh
ERROR: spelling failed

@marosset marosset force-pushed the starter-azure-minio-updates branch from c448cee to 4f82c68 Compare December 9, 2024 22:06
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2024
@matthyx
Copy link
Contributor

matthyx commented Dec 10, 2024

thanks @marosset !
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marosset, matthyx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2024
@matthyx
Copy link
Contributor

matthyx commented Dec 10, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 10, 2024
@k8s-ci-robot k8s-ci-robot merged commit e4b0fff into kubernetes-sigs:main Dec 10, 2024
6 of 7 checks passed
@hashim21223445 hashim21223445 mentioned this pull request Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants