-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add utility for namespace labels patching and add the test cases for denyNodeFeatureLabels restriction #1990
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: TessaIO The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dac34b7
to
9fb9e67
Compare
…s for denyNodeFeatureLabels restriction Signed-off-by: TessaIO <[email protected]>
9fb9e67
to
4032b02
Compare
/cc @marquiz |
AddOperation = "add" | ||
RemoveOperation = "remove" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would make sense to specify these in pkg/utils/jsonpatch.go
Again, this could be a separate PR converting all uses of utils.NewJsonPatch
to use these definitions.
WDYT?
Also, bike-shedding on the naming, for the generic pkg/utils version:
AddOperation = "add" | |
RemoveOperation = "remove" | |
JSONPatchOpAdd = "add" | |
JSONPatchOpRemove = "remove" |
Resolves #1879