Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for master and garbage collector pod topology spread constraints #1955

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for master and garbage collector pod topology spread constraints #1955

wants to merge 1 commit into from

Conversation

solidDoWant
Copy link

This adds topologySpreadConstraints fields to the master and garbage collector pods via the Helm chart.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Nov 11, 2024 •
edited
Loading

CLA Not Signed

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: solidDoWant
Once this PR has been reviewed and has the lgtm label, please assign arangogutierrez for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 11, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @solidDoWant!

It looks like this is your first PR to kubernetes-sigs/node-feature-discovery 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/node-feature-discovery has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 11, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @solidDoWant. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@netlify Netlify
Copy link

netlify bot commented Nov 11, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 6c60901
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/67489a2ac393d200089aeb0b
😎 Deploy Preview https://deploy-preview-1955--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 11, 2024
@solidDoWant
Copy link
Author

Hey folks I agree to the terms and conditions in the CLA but I'm not going to provide my full name, email, and physical address to submit a minor 13 line feature to this project.

Do whatever you want with this PR and the code I have submitted in it, but I will not be signing the CLA due to privacy concerns.

marquiz
marquiz reviewed Nov 28, 2024
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @solidDoWant for the improvement

Could you sign the CLA (in addition to addressing the one review comment below) so that we could proceed with the PR?

deployment/helm/node-feature-discovery/templates/nfd-gc.yaml Outdated
@@ -85,4 +85,8 @@ spec:
tolerations:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- with .Values.gc.topologySpreadConstraints }}
tolerations:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tolerations??

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry - fixed this but forgot to push.

@solidDoWant
Copy link
Author

Could you sign the CLA

#1955 (comment)

@marquiz
Copy link
Contributor

marquiz commented Nov 29, 2024

Hey folks I agree to the terms and conditions in the CLA but I'm not going to provide my full name, email, and physical address to submit a minor 13 line feature to this project.

Do whatever you want with this PR and the code I have submitted in it, but I will not be signing the CLA due to privacy concerns.

Oh, sorry to hear that 😢 Unfortunately it's a requirement for kubernetes projects to have the CLA signed before accepting contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marquiz marquiz marquiz left review comments

@PiotrProkop PiotrProkop Awaiting requested review from PiotrProkop

Assignees
No one assigned
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@solidDoWant @k8s-ci-robot @marquiz