nfd-topology-updater: serve metrics and healthz on the same port #1947
+43
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
the
size/L
k8s-ci-robot
added
the
do-not-merge/hold
marquiz
force-pushed
the
devel/health-topology-updater
branch
from
76337ed to
a894cb8
Compare
|
/assign @ArangoGutierrez |
k8s-ci-robot
added
the
needs-rebase
fmuyassarov
reviewed
Nov 7, 2024
| flagset.IntVar(&args.GrpcHealthPort, "grpc-health", 8082, | ||
| "Port on which to expose the grpc health endpoint.") | ||
| flagset.IntVar(&args.Port, "port", 8080, | ||
| "Port on which to metrics and healthz endpoints are served") |
There was a problem hiding this comment.
Suggested change
| "Port on which to metrics and healthz endpoints are served") | |
| "Port on which metrics and healthz endpoints are served") |
nit
There was a problem hiding this comment.
and it would be nice to fix it on #1946 too
Changes the gRPC health endpoint to plain http. At the same time starts serving both the metrics and healthz endpoints on a single port. Replaces the -metrics and -grpc-health command line flags with a single -port flag. Changes the Helm and kustomize deployments correspondingly.
marquiz
force-pushed
the
devel/health-topology-updater
branch
from
a894cb8 to
2ac758c
Compare
k8s-ci-robot
removed
the
needs-rebase
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/retest |
1 similar comment
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the gRPC health endpoint to plain http. At the same time starts serving both the metrics and healthz endpoints on a single port. Replaces the -metrics and -grpc-health command line flags with a single -port flag.
Changes the Helm and kustomize deployments correspondingly.