Bump sigs.k8s.io/jobset from 0.5.2 to 0.6.0 #2898
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [sigs.k8s.io/jobset](https://github.com/kubernetes-sigs/jobset) from 0.5.2 to 0.6.0. - [Release notes](https://github.com/kubernetes-sigs/jobset/releases) - [Changelog](https://github.com/kubernetes-sigs/jobset/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/jobset@v0.5.2...v0.6.0) --- updated-dependencies: - dependency-name: sigs.k8s.io/jobset dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
ok-to-test
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dependabot[bot] The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/XXL
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@dependabot[bot]: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/hold We are waiting for a K8s bump to merge this. Jobset was updated to use 0.30. |
k8s-ci-robot
added
the
do-not-merge/hold
|
why is that a problem? Kueue is already on k8s 0.30 libraries. |
No, we still have v0.29.8 (https://github.com/kubernetes-sigs/kueue/blob/main/go.mod#L24). |
|
oh, interestingly, we upgraded apimachinery. Can you upgrade before we upgrade to v1.31? |
Unfortunately, no. We already had an issue that was fixed on v1.31.0 (kubernetes/kubernetes#125499). So that's why was skipped v1.30.x |
|
@mimowo was pushing pretty hard for jobset 0.6.0 for Kueue integration (#2700). I'm not sure how important this is but we would need this PR for this to work and we depend on jobset 0.6.0 which requires 0.30 APIs for K8s. I see the issue now. If the Kueue + JobSet bug fix is important, than maybe we consider merging the 0.31 API update before the first patch? |
|
k8s 1.31.0 is released, so could we use it in Kueue to unblock bumping JobSet? |
No, due to #2402 (comment). |
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This should be unblocked after #2402 is merged. Still, I would suggest to open a dedicated PR to say that JobSet 0.6 is supported in release notes (not sure we can update dependabot's PR with that). |
|
I opened up a separate PR because this seems to have issues. I can't do the normal dependabot commands. |
|
/close |
|
@kannon92: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
dependabot
bot
deleted the
dependabot/go_modules/sigs.k8s.io/jobset-0.6.0
branch
Bumps sigs.k8s.io/jobset from 0.5.2 to 0.6.0.
Release notes
Sourced from sigs.k8s.io/jobset's releases.
... (truncated)
Commits
d66f1d5update to k8s 0.30.4 (#654)226e14cBump github.com/prometheus/client_golang from 1.19.1 to 1.20.0 (#653)7886910Add new job-id annotation to assign globally unique job index to each job (#650)ec39730Merge pull request #647 from kubernetes-sigs/dependabot/go_modules/github.com...71194caMerge pull request #642 from kannon92/fully-label-namea7eba1cadd the unparam linter to golangci and fix those issues flagged (#643)e1523dbBump github.com/onsi/ginkgo/v2 from 2.19.1 to 2.20.0f7f3b28refactor jobset webhook (#646)8bade1eMerge pull request #644 from mimowo/fix-suspendc89e112Review remarksDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)