Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve debuggability in jobset controller tests #2315

Merged
merged 1 commit into from
May 30, 2024
Merged

improve debuggability in jobset controller tests #2315

merged 1 commit into from
May 30, 2024

Conversation

mszadkow
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Improve debuggability of jobset controller tests as requested here

Which issue(s) this PR fixes:

Fixes #2227

Special notes for your reviewer:

Does this PR introduce a user-facing change?

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 29, 2024
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 29, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @mszadkow. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 29, 2024
@netlify Netlify
Copy link

netlify bot commented May 29, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit d33eb0f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/665770b0868fb2000719958d

@mszadkow
Copy link
Contributor Author

@tenzen-y please review, I followed your comments to pass gomega.Gomega to other Eventually in the same file

@tenzen-y
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 29, 2024
@mszadkow mszadkow force-pushed the follow-up-on-2268 branch from 67c6f1d to 0de2cd0 Compare May 29, 2024 13:56
@mszadkow mszadkow marked this pull request as ready for review May 29, 2024 13:57
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 29, 2024
@k8s-ci-robot k8s-ci-robot requested a review from trasc May 29, 2024 13:57
mimowo
mimowo reviewed May 29, 2024
View reviewed changes
test/integration/controller/jobs/jobset/jobset_controller_test.go Outdated
gomega.Eventually(func() bool {
gomega.Eventually(func(g gomega.Gomega) {
g.Expect(k8sClient.Get(ctx, lookupKey, createdJobSet)).Should(gomega.Succeed())
g.Expect(createdJobSet.Spec.Suspend).ShouldNot(gomega.BeNil())
Copy link
Contributor

@mimowo mimowo May 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check does not look necessary given the check below. Same in other places below.

mimowo
mimowo reviewed May 29, 2024
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the nit about the unnecessary check

tenzen-y
tenzen-y reviewed May 29, 2024
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
/approve

After you address @mimowo 's comments, we can merge this PR.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mszadkow, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2024
@tenzen-y
Copy link
Member

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 29, 2024
@mszadkow mszadkow force-pushed the follow-up-on-2268 branch from 0de2cd0 to d33eb0f Compare May 29, 2024 18:15
tenzen-y
tenzen-y reviewed May 30, 2024
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution!
Thank you!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5c011c76aaea0e29efc43a9aabad4e906759b400

@k8s-ci-robot k8s-ci-robot merged commit 063abd6 into kubernetes-sigs:main May 30, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone May 30, 2024
@mszadkow mszadkow deleted the follow-up-on-2268 branch June 3, 2024 09:28
@mszadkow mszadkow mentioned this pull request Jun 21, 2024
Closed
11 tasks
kannon92 pushed a commit to openshift-kannon92/kubernetes-sigs-kueue that referenced this pull request Nov 19, 2024
@mszadkow @kannon92
improve debuggability in jobset controller tests (kubernetes-sigs#2315)
b304b6e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@mimowo mimowo mimowo left review comments

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@denkensk denkensk Awaiting requested review from denkensk

@trasc trasc Awaiting requested review from trasc

Assignees

@tenzen-y tenzen-y

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.

Jobsets having replicas = 0 for their replicatedJob are not handled in Kueue
4 participants
@mszadkow @k8s-ci-robot @tenzen-y @mimowo