Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGNORE #4483

Conversation

camilamacedo86
Copy link
Member

No description provided.

damsien and others added 30 commits November 7, 2024 13:03
…t-manager-managed serving-cert with TLS verification

Adds a patch to configure ServiceMonitor with  `insecureSkipVerify: false`  to ensure TLS verification using cert-manager certificates. Updates documentation and corrects misaligned comments.
…t-mamager-service-monitor

✨ Adds a patch to configure ServiceMonitor with to ensure TLS verification using cert-manager certificates
… projects

- Removed the comment about `seccompProfile` as `type: RuntimeDefault` is now set by default.
- Updated to reflect that Kubebuilder only tests and supports the latest three Kubernetes releases.
- Given that we’re currently using Kubernetes 1.31, there’s no longer a reason to keep this line commented, ensuring projects adhere to `restricted` Pod Security Standards by default.
✨ Include admin ClusterRole and add it to the scaffold
…mment-line-ensure-all-restricted

✨  (go/v4): Enable `seccompProfile.type: RuntimeDefault` by default in scaffolded projects
Add helm plugin to distribute projects

This PR introduces an optional Helm plugin, enabling users to scaffold Helm charts for Kubebuilder projects.

- **Helm Chart Scaffolding**: Allows generation of a Helm chart under the `dist/chart` directory, providing an alternative for distributing and managing projects via Helm.
- **Usage**:
  - **To add when init the project**: `kubebuilder init --plugins=helm/v1-alpha` for new projects.
  - **To Init/Update in a project previously scaffolded**: `kubebuilder edit --plugins=helm/v1-alpha` to add or update Helm charts for existing projects.
- **Sync Helm Chart**: Syncs the Helm chart with project manifests using the `edit` command, with `--force` required for updates after webhook or `DeployImage` plugin changes in order to overwritten the values.yaml and manager.yaml files.
… metrics-server-cert secret

This change ensures that only the necessary permissions are granted for accessing the metrics-server-cert secret. Note that setting defaultMode: 420 is not required.
Add latest status of helm plugin since it's initial version is implemented
…proposal

 📖 Proposal : New Plugin to allow project distribution via helm charts
When we rebase with the latest changes those infos to clarify the usage of the options get lost.
In this commit we are introducing the missed info to help users know how to use the chart
…ssions

✨ Follow-up to PR kubernetes-sigs#4243: Limit permissions to access the metrics-server-cert secret
…pdate-nov

📖 doc: update roadmap for 2024
…crd-keep

✨ (helm/v1-alpha): add missed info to chart values
Bumps [sigs.k8s.io/kubebuilder/v4](https://github.com/kubernetes-sigs/kubebuilder) from 4.3.0 to 4.3.1.
- [Release notes](https://github.com/kubernetes-sigs/kubebuilder/releases)
- [Changelog](https://github.com/kubernetes-sigs/kubebuilder/blob/master/RELEASE.md)
- [Commits](kubernetes-sigs/kubebuilder@v4.3.0...v4.3.1)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/kubebuilder/v4
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
…ot/go_modules/docs/book/src/simple-external-plugin-tutorial/testdata/sampleexternalplugin/v1/sigs.k8s.io/kubebuilder/v4-4.3.1

📖 Bump sigs.k8s.io/kubebuilder/v4 from 4.3.0 to 4.3.1 in /docs/book/src/simple-external-plugin-tutorial/testdata/sampleexternalplugin/v1
…e-plugin

📖 Fix readme wrong url your-own-plugin
Signed-off-by: Emmanuel Ferdman <[email protected]>
…4331)

Revert "🌱 : Fix `make remove-spaces` for GNU system (kubernetes-sigs#4330)"

This reverts commit d8f4da2.
mateusoliveira43 and others added 10 commits January 2, 2025 06:14
Fix linter error `nilness: impossible condition: nil != nil (govet)`

```
golangci-lint run
pkg/plugins/golang/v4/scaffolds/edit.go:60:9: nilness: impossible condition: nil != nil (govet)
	if err != nil && s.multigroup != s.config.IsMultiGroup() {
	       ^
make: *** [lint] Error 1
```

Signed-off-by: Mateus Oliveira <[email protected]>
fix: simplify E2E Book Samples job

Signed-off-by: Mateus Oliveira <[email protected]>
fix: remaining Go upgrades

Signed-off-by: Mateus Oliveira <[email protected]>
fix: remove unused nolint comments

Signed-off-by: Mateus Oliveira <[email protected]>
Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.28.0 to 0.29.0.
- [Release notes](https://github.com/golang/tools/releases)
- [Commits](golang/tools@v0.28.0...v0.29.0)

---
updated-dependencies:
- dependency-name: golang.org/x/tools
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…caffold code (kubernetes-sigs#4471)

fix: remove unnecessary make manifest and make generate in E2E scaffold code

Signed-off-by: Mateus Oliveira <[email protected]>
…4480)

Bumps [github.com/spf13/afero](https://github.com/spf13/afero) from 1.11.0 to 1.12.0.
- [Release notes](https://github.com/spf13/afero/releases)
- [Commits](spf13/afero@v1.11.0...v1.12.0)

---
updated-dependencies:
- dependency-name: github.com/spf13/afero
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…m chart values (kubernetes-sigs#4451)

(helm/v1alpha1) - fix webhook generation by removing data from helm chart values

This commit changes the code implementation so that the webhook values in the helm chart are not generated. Instead, only expose the values to enable or not webhooks
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jan 12, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 12, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 12, 2025
@camilamacedo86 camilamacedo86 changed the title Book v4 release branch 📖 Update docs with release v4.4.0 Jan 12, 2025
@camilamacedo86
Copy link
Member Author

The invalid commit message is from dependabot
I will ignore those to move forward with the release.

@camilamacedo86 camilamacedo86 added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jan 12, 2025
@camilamacedo86 camilamacedo86 changed the title 📖 Update docs with release v4.4.0 IGNORE Jan 12, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jan 12, 2025
@k8s-ci-robot
Copy link
Contributor

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@camilamacedo86
Copy link
Member Author

Close in favour of PR generated from GitHub interface directly: #4484

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.