Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Podman test failures caused by kernel update #3527

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

tnqn
Copy link
Contributor

@tnqn tnqn commented Feb 22, 2024

Newer linux kernels like 5.15.0-1056-azure used by Github action runner doesn't allow mode changes of symlinks, leading to failure when creating cluster using Podman with crun < 1.9.1.

The patch fixes it by upgrading crun to newer version when setting up the test env for Podman.

Fixes #3526

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 22, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 22, 2024
Newer linux kernels like 5.15.0-1056-azure used by Github action runner
doesn't allow mode changes of symlinks, leading to failure when creating
cluster using Podman with crun < 1.9.1.

The patch fixes it by upgrading crun to newer version when setting up
the test env for Podman.

Signed-off-by: Quan Tian <[email protected]>
@tnqn tnqn marked this pull request as ready for review February 22, 2024 08:46
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 22, 2024
@@ -55,6 +55,11 @@ jobs:
# https://github.com/actions/virtual-environments/issues/2708
sudo apt-get update
sudo apt-get -y install dnsmasq
# crun >= 1.9.1 is required on Ubuntu 20.04.6
# https://github.com/kubernetes-sigs/kind/issues/3526
curl -Lo ./crun https://github.com/containers/crun/releases/download/1.14.3/crun-1.14.3-linux-amd64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: integrity check

Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, tnqn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit d59e2ce into kubernetes-sigs:main Feb 22, 2024
19 checks passed
@tnqn tnqn deleted the fix-podman-test branch February 23, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kind with podman fails to create cluster on Ubuntu 20.04.6 (kernel 5.15.0-1056-azure and likely more versions)
3 participants