-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Podman test failures caused by kernel update #3527
Conversation
Skipping CI for Draft Pull Request. |
Newer linux kernels like 5.15.0-1056-azure used by Github action runner doesn't allow mode changes of symlinks, leading to failure when creating cluster using Podman with crun < 1.9.1. The patch fixes it by upgrading crun to newer version when setting up the test env for Podman. Signed-off-by: Quan Tian <[email protected]>
95b8deb
to
62a9420
Compare
@@ -55,6 +55,11 @@ jobs: | |||
# https://github.com/actions/virtual-environments/issues/2708 | |||
sudo apt-get update | |||
sudo apt-get -y install dnsmasq | |||
# crun >= 1.9.1 is required on Ubuntu 20.04.6 | |||
# https://github.com/kubernetes-sigs/kind/issues/3526 | |||
curl -Lo ./crun https://github.com/containers/crun/releases/download/1.14.3/crun-1.14.3-linux-amd64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: integrity check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, tnqn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Newer linux kernels like 5.15.0-1056-azure used by Github action runner doesn't allow mode changes of symlinks, leading to failure when creating cluster using Podman with crun < 1.9.1.
The patch fixes it by upgrading crun to newer version when setting up the test env for Podman.
Fixes #3526