Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ipFamily validation #3483

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Add ipFamily validation #3483

merged 1 commit into from
Feb 22, 2024

Conversation

tnqn
Copy link
Contributor

@tnqn tnqn commented Jan 18, 2024

Setting ipFamily to invalid value didn't return any error and kind just created an ipv4 cluster silently. It could be a bit confusing when it is set to some plausible but invalid values like IPv4, IPv6, Dual, ds.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 18, 2024
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 18, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @tnqn. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 18, 2024
@aojea
Copy link
Contributor

aojea commented Feb 14, 2024

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, tnqn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2024
@BenTheElder
Copy link
Member

/hold
[going to merge this after we tag the next patch release currently in flight, just because that release is already a regression fix]

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2024
@BenTheElder
Copy link
Member

/hold cancel
/test all

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2024
@tnqn
Copy link
Contributor Author

tnqn commented Feb 20, 2024

/test all

@tnqn
Copy link
Contributor Author

tnqn commented Feb 20, 2024

@aojea @BenTheElder it seems specific role is needed to rerun the failed github actions, could you help rerun them?

@aojea
Copy link
Contributor

aojea commented Feb 21, 2024

@aojea @BenTheElder it seems specific role is needed to rerun the failed github actions, could you help rerun them?

rebase and repush, I think that it triggers the github actions again

@tnqn
Add ipFamily validation
396586f 
Setting ipFamily to invalid value didn't return any error and kind just
created an ipv4 cluster silently. It could be a bit confusing when it is
set to some plausible but invalid values like IPv4, IPv6, Dual, ds.

Signed-off-by: Quan Tian <[email protected]>
@tnqn tnqn force-pushed the validate-ip-family branch from 1b631bd to 396586f Compare February 22, 2024 03:39
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2024
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@tnqn
Copy link
Contributor Author

tnqn commented Feb 22, 2024

/retest

@tnqn tnqn closed this Feb 22, 2024
@tnqn tnqn reopened this Feb 22, 2024
@tnqn tnqn mentioned this pull request Feb 22, 2024
Closed
@BenTheElder
Copy link
Member

we can manually re-run, but I think actions only picks up config changes in the current branch

I'm OK merging this without the actions passing since they're not really testing for this and the change isn't node-runtime specific, we can always manually bypass.

@BenTheElder BenTheElder merged commit 2fb3f42 into kubernetes-sigs:main Feb 22, 2024
32 of 37 checks passed
@tnqn tnqn deleted the validate-ip-family branch February 23, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

@neolit123 neolit123 Awaiting requested review from neolit123

Assignees

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tnqn @k8s-ci-robot @aojea @BenTheElder