Adding a . as a valid character for Modules' name.

[ybettan]

When a Module is deleted, the NMC controller is removing the labels for this Module in the NMC object.

As long as those labels for a specific module exists, the module's finalizer will not be removed upon module deletion and the module will keep hanging forever if deleted.

When a module is created with a . in its name, the created label for NMC doesn't match the expected regexp for this label and, therefore, not removed upon module's deletion.

Adding the . will allow the label to match the regexp, be removed upon deletion and deleting the module gracefully.

---

/assign @yevgeny-shnaidman
/cc @TomerNewman
Fixes #967

[k8s-ci-robot]

@ybettan: GitHub didn't allow me to request PR reviews from the following users: TomerNewman.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

When a Module is deleted, the NMC controller is removing the labels for this Module in the NMC object.

As long as those labels for a specific module exists, the module's finalizer will not be removed upon module deletion and the module will keep hanging forever if deleted.

When a module is created with a . in its name, the created label for NMC doesn't match the expected regexp for this label and, therefore, not removed upon module's deletion.

Adding the . will allow the label to match the regexp, be removed upon deletion and deleting the module gracefully.

---

/assign @yevgeny-shnaidman
/cc @TomerNewman
Fixes #967

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ybettan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ybettan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[netlify]

✅ Deploy Preview for kubernetes-sigs-kmm ready!

Name	Link
🔨 Latest commit	0b6d54d
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kmm/deploys/677fba505cf2fa0008b8008c
😎 Deploy Preview	https://deploy-preview-969--kubernetes-sigs-kmm.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.68%. Comparing base (fa23a9b) to head (0b6d54d).
Report is 169 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #969      +/-   ##
==========================================
- Coverage   79.09%   72.68%   -6.42%     
==========================================
  Files          51       65      +14     
  Lines        5109     5762     +653     
==========================================
+ Hits         4041     4188     +147     
- Misses        882     1395     +513     
+ Partials      186      179       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yevgeny-shnaidman]

looks good, but lets add unit-test that verify the new regex

[ybettan]

looks good, but lets add unit-test that verify the new regex

Good catch :)
Done.

[yevgeny-shnaidman]

/lgtm